deprecated .get() in favor of .value

ljharb · Sep 4, 2010 · a8d1645 · a8d1645
1 parent f018025
commit a8d1645
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/lib/traverse.js b/lib/traverse.js
@@ -38,14 +38,17 @@ function Traverse (refObj) {
             return ref;
         }
     }
-    var obj = clone(refObj);
+    this.value = clone(refObj);
 
-    this.get = function () { return obj };
+    // get() is deprecated, use .value
+    this.get = function () { return this.value };
 
     this.map = function (f) {
+        var self = this;
+
         var path = [];
         var parents = [];
-        walk(obj);
+        walk(this.value);
         return this;
 
         function walk (node) {
@@ -54,10 +57,10 @@ function Traverse (refObj) {
                 path : [].concat(path),
                 parent : parents.slice(-1)[0],
                 key : path.slice(-1)[0],
-                isRoot : node == obj,
+                isRoot : node == self.value,
                 update : function (x) {
                     if (state.isRoot) {
-                        obj = x;
+                        self.value = x;
                     }
                     else {
                         state.parent.node[state.key] = x;

diff --git a/test/json.js b/test/json.js
@@ -13,7 +13,7 @@ exports['json test'] = function (assert) {
             this.update('[Function]');
             id++;
         }
-    }).get();
+    }).value;
 
     assert.equal(
         scrubbed.moo, '[Function]',

diff --git a/test/negative.js b/test/negative.js
@@ -6,7 +6,7 @@ exports['negative update test'] = function (assert) {
     var obj = [ 5, 6, -3, [ 7, 8, -2, 1 ], { f : 10, g : -13 } ];
     var fixed = Traverse(obj).map(function (x) {
         if (x < 0) this.update(x + 128);
-    }).get();
+    }).value;
 
     assert.equal(
         sys.inspect(fixed),