[Fix] work around npm-packlist bug

ljharb · Dec 9, 2023 · 207e4e9 · 207e4e9
1 parent a03f3e8
commit 207e4e9
Show file tree

Hide file tree

Showing 9 changed files with 8 additions and 14 deletions.
diff --git a/packages/list-exports/index.js b/packages/list-exports/index.js
@@ -786,6 +786,11 @@ async function getExports(packageDir, pkgData, nodeRange, problems) {
 				flatMap(
 					packedFiles,
 					(x) => {
+						// hack to work around npm-packlist bug
+						if (x.split('/').indexOf('node_modules') > -1) {
+							return [];
+						}
+
 						const resolved = resolveFrom(dirname(x), packageDir, rootAllExtensions);
 						return [
 							x,

diff --git a/packages/tests/fixtures/single-spa-layout/expected/broken-dir-slash-conditions.json b/packages/tests/fixtures/single-spa-layout/expected/broken-dir-slash-conditions.json
@@ -5,7 +5,6 @@
 		"node": "*"
 	},
 	"problems": [
-		"`./node_modules/@types/parse5` has a `package.json`, but both its `main` and `index.js` do not exist!",
 		"`./package.json`: inside a conditions object, a files object (keys starting with `.`) is invalid"
 	],
 	"exports": {

diff --git a/packages/tests/fixtures/single-spa-layout/expected/broken.json b/packages/tests/fixtures/single-spa-layout/expected/broken.json
@@ -4,9 +4,7 @@
 	"engines": {
 		"node": "*"
 	},
-	"problems": [
-		"`./node_modules/@types/parse5` has a `package.json`, but both its `main` and `index.js` do not exist!"
-	],
+	"problems": [],
 	"exports": {
 		"binaries": {},
 		"latest": "broken",

diff --git a/packages/tests/fixtures/single-spa-layout/expected/conditions.json b/packages/tests/fixtures/single-spa-layout/expected/conditions.json
@@ -5,7 +5,6 @@
 		"node": "*"
 	},
 	"problems": [
-		"`./node_modules/@types/parse5` has a `package.json`, but both its `main` and `index.js` do not exist!",
 		"`./package.json`: inside a conditions object, a files object (keys starting with `.`) is invalid"
 	],
 	"exports": {

diff --git a/packages/tests/fixtures/single-spa-layout/expected/experimental.json b/packages/tests/fixtures/single-spa-layout/expected/experimental.json
@@ -4,9 +4,7 @@
 	"engines": {
 		"node": "*"
 	},
-	"problems": [
-		"`./node_modules/@types/parse5` has a `package.json`, but both its `main` and `index.js` do not exist!"
-	],
+	"problems": [],
 	"exports": {
 		"binaries": {},
 		"latest": "experimental",

diff --git a/packages/tests/fixtures/single-spa-layout/expected/pattern-trailers-no-dir-slash.json b/packages/tests/fixtures/single-spa-layout/expected/pattern-trailers-no-dir-slash.json
@@ -5,7 +5,6 @@
 		"node": "*"
 	},
 	"problems": [
-		"`./node_modules/@types/parse5` has a `package.json`, but both its `main` and `index.js` do not exist!",
 		"`./package.json`: inside a conditions object, a files object (keys starting with `.`) is invalid"
 	],
 	"exports": {

diff --git a/packages/tests/fixtures/single-spa-layout/expected/pattern-trailers.json b/packages/tests/fixtures/single-spa-layout/expected/pattern-trailers.json
@@ -5,7 +5,6 @@
 		"node": "*"
 	},
 	"problems": [
-		"`./node_modules/@types/parse5` has a `package.json`, but both its `main` and `index.js` do not exist!",
 		"`./package.json`: inside a conditions object, a files object (keys starting with `.`) is invalid"
 	],
 	"exports": {

diff --git a/packages/tests/fixtures/single-spa-layout/expected/patterns.json b/packages/tests/fixtures/single-spa-layout/expected/patterns.json
@@ -5,7 +5,6 @@
 		"node": "*"
 	},
 	"problems": [
-		"`./node_modules/@types/parse5` has a `package.json`, but both its `main` and `index.js` do not exist!",
 		"`./package.json`: inside a conditions object, a files object (keys starting with `.`) is invalid"
 	],
 	"exports": {

diff --git a/packages/tests/fixtures/single-spa-layout/expected/pre-exports.json b/packages/tests/fixtures/single-spa-layout/expected/pre-exports.json
@@ -4,9 +4,7 @@
 	"engines": {
 		"node": "*"
 	},
-	"problems": [
-		"`./node_modules/@types/parse5` has a `package.json`, but both its `main` and `index.js` do not exist!"
-	],
+	"problems": [],
 	"exports": {
 		"binaries": {},
 		"latest": "pre-exports",