[Fix] properly handle the graph and the root being identical

Co-authored-by: Matt Travi <programmer@travi.org> Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb · Sep 18, 2021 · c0d5356 · c0d5356
1 parent b91f667
commit c0d5356
Show file tree

Hide file tree

Showing 39 changed files with 11,060 additions and 1 deletion.
diff --git a/bin/ls-engines b/bin/ls-engines
@@ -171,7 +171,7 @@ async function checkEngines(rootNode, rootValids, graphValids, displayRange, sho
 	const superset = [];
 	selectedEngines.forEach((engine) => {
 		const all = new Set(rootValids[engine].concat(graphValids[engine]));
-		const isSame = all.size === rootValids[engine.length] && all.size === graphValids[engine].length;
+		const isSame = all.size === rootValids[engine].length && all.size === graphValids[engine].length;
 		const rootIsSubsetOfGraph = isSubset(rootValids[engine], graphValids[engine]);
 		const graphIsSubsetOfRoot = isSubset(graphValids[engine], rootValids[engine]);
 		if (isSame) {

diff --git a/test/fixtures/graph-root-same/actual-code b/test/fixtures/graph-root-same/actual-code
@@ -0,0 +1 @@
+SUCCESS
diff --git a/test/fixtures/graph-root-same/actual-dev-code b/test/fixtures/graph-root-same/actual-dev-code
@@ -0,0 +1 @@
+INEXACT
diff --git a/test/fixtures/graph-root-same/actual-dev-stderr b/test/fixtures/graph-root-same/actual-dev-stderr
@@ -0,0 +1,6 @@
+Your “engines” field allows more node versions than your dependency graph does.
+
+If you want to narrow your support, you can run `ls-engines --save`, or manually add the following to your `package.json`:
+"engines": {
+  "node": "^16 || ^15 || ^14.13 || ^12.20"
+}
diff --git a/test/fixtures/graph-root-same/actual-dev-stdout b/test/fixtures/graph-root-same/actual-dev-stdout
@@ -0,0 +1,11 @@
+`node_modules` found, mode is “actual”; loading tree from disk...
+
+Valid node version range: ^16 || ^15 || ^14.13 || ^12.20
+
+Currently available latest releases of each valid node major version: <node versions for above semver range>
+
+┌────────┬─────────────────┬─────────────────┬──────────────────────────┐
+│ engine │ current version │ valid (package) │ valid (dependency graph) │
+├────────┼─────────────────┼─────────────────┼──────────────────────────┤
+│ node   │ ${process.version} │ yes!            │ yes!                     │
+└────────┴─────────────────┴─────────────────┴──────────────────────────┘
diff --git a/test/fixtures/graph-root-same/actual-peer-code b/test/fixtures/graph-root-same/actual-peer-code
@@ -0,0 +1 @@
+SUCCESS
diff --git a/test/fixtures/graph-root-same/actual-peer-stderr b/test/fixtures/graph-root-same/actual-peer-stderr
diff --git a/test/fixtures/graph-root-same/actual-peer-stdout b/test/fixtures/graph-root-same/actual-peer-stdout
@@ -0,0 +1,13 @@
+`node_modules` found, mode is “actual”; loading tree from disk...
+
+Valid node version range: ^16 || ^15 || ^14 || ^13 || ^12 || ^11 || ^10
+
+Currently available latest releases of each valid node major version: <node versions for above semver range>
+
+Your “engines” field exactly matches your dependency graph’s requirements!
+
+┌────────┬─────────────────┬─────────────────┬──────────────────────────┐
+│ engine │ current version │ valid (package) │ valid (dependency graph) │
+├────────┼─────────────────┼─────────────────┼──────────────────────────┤
+│ node   │ ${process.version} │ yes!            │ yes!                     │
+└────────┴─────────────────┴─────────────────┴──────────────────────────┘
diff --git a/test/fixtures/graph-root-same/actual-production-code b/test/fixtures/graph-root-same/actual-production-code
@@ -0,0 +1 @@
+SUCCESS
diff --git a/test/fixtures/graph-root-same/actual-production-stderr b/test/fixtures/graph-root-same/actual-production-stderr
diff --git a/test/fixtures/graph-root-same/actual-production-stdout b/test/fixtures/graph-root-same/actual-production-stdout
@@ -0,0 +1,13 @@
+`node_modules` found, mode is “actual”; loading tree from disk...
+
+Valid node version range: ^16 || ^15 || ^14 || ^13 || ^12 || ^11 || ^10
+
+Currently available latest releases of each valid node major version: <node versions for above semver range>
+
+Your “engines” field exactly matches your dependency graph’s requirements!
+
+┌────────┬─────────────────┬─────────────────┬──────────────────────────┐
+│ engine │ current version │ valid (package) │ valid (dependency graph) │
+├────────┼─────────────────┼─────────────────┼──────────────────────────┤
+│ node   │ ${process.version} │ yes!            │ yes!                     │
+└────────┴─────────────────┴─────────────────┴──────────────────────────┘
diff --git a/test/fixtures/graph-root-same/actual-stderr b/test/fixtures/graph-root-same/actual-stderr
diff --git a/test/fixtures/graph-root-same/actual-stdout b/test/fixtures/graph-root-same/actual-stdout
@@ -0,0 +1,13 @@
+`node_modules` found, mode is “actual”; loading tree from disk...
+
+Valid node version range: ^16 || ^15 || ^14 || ^13 || ^12 || ^11 || ^10
+
+Currently available latest releases of each valid node major version: <node versions for above semver range>
+
+Your “engines” field exactly matches your dependency graph’s requirements!
+
+┌────────┬─────────────────┬─────────────────┬──────────────────────────┐
+│ engine │ current version │ valid (package) │ valid (dependency graph) │
+├────────┼─────────────────┼─────────────────┼──────────────────────────┤
+│ node   │ ${process.version} │ yes!            │ yes!                     │
+└────────┴─────────────────┴─────────────────┴──────────────────────────┘
diff --git a/test/fixtures/graph-root-same/ideal-code b/test/fixtures/graph-root-same/ideal-code
@@ -0,0 +1 @@
+SUCCESS
diff --git a/test/fixtures/graph-root-same/ideal-dev-code b/test/fixtures/graph-root-same/ideal-dev-code
@@ -0,0 +1 @@
+INEXACT
diff --git a/test/fixtures/graph-root-same/ideal-dev-stderr b/test/fixtures/graph-root-same/ideal-dev-stderr
@@ -0,0 +1,6 @@
+Your “engines” field allows more node versions than your dependency graph does.
+
+If you want to narrow your support, you can run `ls-engines --save`, or manually add the following to your `package.json`:
+"engines": {
+  "node": "^16 || ^15 || ^14.13 || ^12.20"
+}
diff --git a/test/fixtures/graph-root-same/ideal-dev-stdout b/test/fixtures/graph-root-same/ideal-dev-stdout
@@ -0,0 +1,11 @@
+`package.json` found, mode is “ideal”; building ideal tree from `package.json`...
+
+Valid node version range: ^16 || ^15 || ^14.13 || ^12.20
+
+Currently available latest releases of each valid node major version: <node versions for above semver range>
+
+┌────────┬─────────────────┬─────────────────┬──────────────────────────┐
+│ engine │ current version │ valid (package) │ valid (dependency graph) │
+├────────┼─────────────────┼─────────────────┼──────────────────────────┤
+│ node   │ ${process.version} │ yes!            │ yes!                     │
+└────────┴─────────────────┴─────────────────┴──────────────────────────┘
diff --git a/test/fixtures/graph-root-same/ideal-peer-code b/test/fixtures/graph-root-same/ideal-peer-code
@@ -0,0 +1 @@
+SUCCESS
diff --git a/test/fixtures/graph-root-same/ideal-peer-stderr b/test/fixtures/graph-root-same/ideal-peer-stderr
diff --git a/test/fixtures/graph-root-same/ideal-peer-stdout b/test/fixtures/graph-root-same/ideal-peer-stdout
@@ -0,0 +1,13 @@
+`package.json` found, mode is “ideal”; building ideal tree from `package.json`...
+
+Valid node version range: ^16 || ^15 || ^14 || ^13 || ^12 || ^11 || ^10
+
+Currently available latest releases of each valid node major version: <node versions for above semver range>
+
+Your “engines” field exactly matches your dependency graph’s requirements!
+
+┌────────┬─────────────────┬─────────────────┬──────────────────────────┐
+│ engine │ current version │ valid (package) │ valid (dependency graph) │
+├────────┼─────────────────┼─────────────────┼──────────────────────────┤
+│ node   │ ${process.version} │ yes!            │ yes!                     │
+└────────┴─────────────────┴─────────────────┴──────────────────────────┘
diff --git a/test/fixtures/graph-root-same/ideal-production-code b/test/fixtures/graph-root-same/ideal-production-code
@@ -0,0 +1 @@
+SUCCESS
diff --git a/test/fixtures/graph-root-same/ideal-production-stderr b/test/fixtures/graph-root-same/ideal-production-stderr
diff --git a/test/fixtures/graph-root-same/ideal-production-stdout b/test/fixtures/graph-root-same/ideal-production-stdout
@@ -0,0 +1,13 @@
+`package.json` found, mode is “ideal”; building ideal tree from `package.json`...
+
+Valid node version range: ^16 || ^15 || ^14 || ^13 || ^12 || ^11 || ^10
+
+Currently available latest releases of each valid node major version: <node versions for above semver range>
+
+Your “engines” field exactly matches your dependency graph’s requirements!
+
+┌────────┬─────────────────┬─────────────────┬──────────────────────────┐
+│ engine │ current version │ valid (package) │ valid (dependency graph) │
+├────────┼─────────────────┼─────────────────┼──────────────────────────┤
+│ node   │ ${process.version} │ yes!            │ yes!                     │
+└────────┴─────────────────┴─────────────────┴──────────────────────────┘
diff --git a/test/fixtures/graph-root-same/ideal-stderr b/test/fixtures/graph-root-same/ideal-stderr
diff --git a/test/fixtures/graph-root-same/ideal-stdout b/test/fixtures/graph-root-same/ideal-stdout
@@ -0,0 +1,13 @@
+`package.json` found, mode is “ideal”; building ideal tree from `package.json`...
+
+Valid node version range: ^16 || ^15 || ^14 || ^13 || ^12 || ^11 || ^10
+
+Currently available latest releases of each valid node major version: <node versions for above semver range>
+
+Your “engines” field exactly matches your dependency graph’s requirements!
+
+┌────────┬─────────────────┬─────────────────┬──────────────────────────┐
+│ engine │ current version │ valid (package) │ valid (dependency graph) │
+├────────┼─────────────────┼─────────────────┼──────────────────────────┤
+│ node   │ ${process.version} │ yes!            │ yes!                     │
+└────────┴─────────────────┴─────────────────┴──────────────────────────┘