Add || true to .bashrc lines in case set -e is on #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the (super-rare) case that someone does something like:
and the nvm lines are the last two lines in the shell script, and the nvm directory doesn't exist, the bashrc will return 1 as the exit code, killing the parent shell.
To be honest I'm not sure it's worth fixing this edge case, most people who aren't writing scripts don't have
set -e
in their shell, and most people writing shell scripts aren't sourcing theirAn alternative workaround for this is to add
; true
(or; :
for maximum opacity) instead of|| true
), but I feel like|| true
is most obvious.I tested this by doing:
and it seems to work, I should probably test it more though.
Refs: nodejs/build#988