ignore non-string delimiters

ljharb · Aug 8, 2014 · 04655ab · 04655ab
1 parent c904f25
commit 04655ab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/parse.js b/lib/parse.js
@@ -15,7 +15,7 @@ var internals = {
 
 internals.parseValues = function (str, delimiter) {
 
-    delimiter = typeof delimiter === 'undefined' ? internals.delimiter : delimiter;
+    delimiter = typeof delimiter === 'string' ? delimiter : internals.delimiter;
 
     var obj = {};
     var parts = str.split(delimiter, internals.parametersLimit);

diff --git a/test/parse.js b/test/parse.js
@@ -252,4 +252,10 @@ describe('#parse', function () {
         expect(Qs.parse('a=b;c=d', ';')).to.deep.equal({ a: 'b', c: 'd' });
         done();
     });
+
+    it('should not use non-string objects as delimiters', function (done) {
+
+        expect(Qs.parse('a=b&c=d', {})).to.deep.equal({ a: 'b', c: 'd' });
+        done();
+    });
 });