[Dev Deps] update eslint, @ljharb/eslint-config, browserify, `i…

…conv-lite`, `qs-iconv`, `tape`
ljharb · Dec 17, 2016 · 2ca339e · 2ca339e
1 parent eb9fbe4
commit 2ca339e
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 19 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -5,13 +5,13 @@
 
     "rules": {
         "complexity": [2, 25],
-        "consistent-return": [1],
+        "consistent-return": 1,
         "id-length": [2, { "min": 1, "max": 25, "properties": "never" }],
         "indent": [2, 4],
         "max-params": [2, 11],
         "max-statements": [2, 42],
-        "no-extra-parens": [1],
-        "no-continue": [1],
+        "no-extra-parens": 1,
+        "no-continue": 1,
         "no-magic-numbers": 0,
         "no-restricted-syntax": [2, "BreakStatement", "DebuggerStatement", "ForInStatement", "LabeledStatement", "WithStatement"],
         "operator-linebreak": 1

diff --git a/lib/parse.js b/lib/parse.js
@@ -16,7 +16,7 @@ var defaults = {
     strictNullHandling: false
 };
 
-var parseValues = function parseValues(str, options) {
+var parseValues = function parseQueryStringValues(str, options) {
     var obj = {};
     var parts = str.split(options.delimiter, options.parameterLimit === Infinity ? undefined : options.parameterLimit);
 
@@ -42,7 +42,7 @@ var parseValues = function parseValues(str, options) {
     return obj;
 };
 
-var parseObject = function parseObject(chain, val, options) {
+var parseObject = function parseObjectRecursive(chain, val, options) {
     if (!chain.length) {
         return val;
     }
@@ -74,7 +74,7 @@ var parseObject = function parseObject(chain, val, options) {
     return obj;
 };
 
-var parseKeys = function parseKeys(givenKey, val, options) {
+var parseKeys = function parseQueryStringKeys(givenKey, val, options) {
     if (!givenKey) {
         return;
     }

diff --git a/lib/stringify.js b/lib/stringify.js
@@ -4,13 +4,13 @@ var utils = require('./utils');
 var formats = require('./formats');
 
 var arrayPrefixGenerators = {
-    brackets: function brackets(prefix) {
+    brackets: function brackets(prefix) { // eslint-disable-line func-name-matching
         return prefix + '[]';
     },
-    indices: function indices(prefix, key) {
+    indices: function indices(prefix, key) { // eslint-disable-line func-name-matching
         return prefix + '[' + key + ']';
     },
-    repeat: function repeat(prefix) {
+    repeat: function repeat(prefix) { // eslint-disable-line func-name-matching
         return prefix;
     }
 };
@@ -21,14 +21,26 @@ var defaults = {
     delimiter: '&',
     encode: true,
     encoder: utils.encode,
-    serializeDate: function serializeDate(date) {
+    serializeDate: function serializeDate(date) { // eslint-disable-line func-name-matching
         return toISO.call(date);
     },
     skipNulls: false,
     strictNullHandling: false
 };
 
-var stringify = function stringify(object, prefix, generateArrayPrefix, strictNullHandling, skipNulls, encoder, filter, sort, allowDots, serializeDate, formatter) {
+var stringify = function stringify( // eslint-disable-line func-name-matching
+    object,
+    prefix,
+    generateArrayPrefix,
+    strictNullHandling,
+    skipNulls,
+    encoder,
+    filter,
+    sort,
+    allowDots,
+    serializeDate,
+    formatter
+) {
     var obj = object;
     if (typeof filter === 'function') {
         obj = filter(prefix, obj);

diff --git a/lib/utils.js b/lib/utils.js
@@ -126,7 +126,7 @@ exports.encode = function (str) {
 
         i += 1;
         c = 0x10000 + (((c & 0x3FF) << 10) | (string.charCodeAt(i) & 0x3FF));
-        out += hexTable[0xF0 | (c >> 18)] + hexTable[0x80 | ((c >> 12) & 0x3F)] + hexTable[0x80 | ((c >> 6) & 0x3F)] + hexTable[0x80 | (c & 0x3F)];
+        out += hexTable[0xF0 | (c >> 18)] + hexTable[0x80 | ((c >> 12) & 0x3F)] + hexTable[0x80 | ((c >> 6) & 0x3F)] + hexTable[0x80 | (c & 0x3F)]; // eslint-disable-line max-len
     }
 
     return out;

diff --git a/package.json b/package.json
@@ -24,17 +24,17 @@
   },
   "dependencies": {},
   "devDependencies": {
-    "@ljharb/eslint-config": "^8.0.0",
-    "browserify": "^13.1.0",
+    "@ljharb/eslint-config": "^9.0.1",
+    "browserify": "^13.1.1",
     "covert": "^1.1.0",
-    "eslint": "^3.8.0",
+    "eslint": "^3.12.2",
     "evalmd": "^0.0.17",
-    "iconv-lite": "^0.4.13",
+    "iconv-lite": "^0.4.15",
     "mkdirp": "^0.5.1",
     "parallelshell": "^2.0.0",
-    "qs-iconv": "^1.0.3",
+    "qs-iconv": "^1.0.4",
     "safe-publish-latest": "^1.1.1",
-    "tape": "^4.6.2"
+    "tape": "^4.6.3"
   },
   "scripts": {
     "prepublish": "safe-publish-latest && npm run dist",

diff --git a/test/.eslintrc b/test/.eslintrc
@@ -1,5 +1,6 @@
 {
     "rules": {
+		"consistent-return": 2,
         "max-lines": 0,
         "max-nested-callbacks": [2, 3],
         "max-statements": 0,

diff --git a/test/stringify.js b/test/stringify.js
@@ -385,7 +385,7 @@ test('stringify()', function (t) {
                 st.equal(prefix, '', 'prefix is empty');
                 st.equal(value, obj);
             } else if (prefix === 'c') {
-                return;
+                return void 0;
             } else if (value instanceof Date) {
                 st.equal(prefix, 'e[f]');
                 return value.getTime();