cleanup for #26

ljharb · Aug 26, 2014 · 5dff4e3 · 5dff4e3
1 parent 0814d70
commit 5dff4e3
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 8 deletions.
diff --git a/lib/utils.js b/lib/utils.js
@@ -3,9 +3,7 @@
 
 // Declare internals
 
-var internals = {
-    returnFalse: function () { return false; }
-};
+var internals = {};
 
 
 exports.arrayToObject = function (source) {
@@ -134,12 +132,18 @@ exports.compact = function (obj) {
     return compacted;
 };
 
+
 exports.isRegExp = function (obj) {
     return Object.prototype.toString.call(obj) === '[object RegExp]';
 };
 
-if (typeof Buffer !== 'undefined') {
-    exports.isBuffer = Buffer.isBuffer;
-} else {
-    exports.isBuffer = internals.returnFalse;
-}
+
+exports.isBuffer = function (obj) {
+
+    if (typeof Buffer !== 'undefined') {
+        return Buffer.isBuffer(obj);
+    }
+    else {
+        return false;
+    }
+};
diff --git a/test/parse.js b/test/parse.js
@@ -322,4 +322,13 @@ describe('#parse', function () {
         expect(result).to.deep.equal(expected);
         done();
     });
+
+    it('does not blow up when Buffer global is missing', function (done) {
+
+        var tempBuffer = global.Buffer;
+        delete global.Buffer;
+        expect(Qs.parse('a=b&c=d')).to.deep.equal({ a: 'b', c: 'd' });
+        global.Buffer = tempBuffer;
+        done();
+    });
 });