[Fix] stringify: when arrayFormat is comma, respect `serializeD…

…ate` Fixes #364.
ljharb · May 2, 2020 · daf3e6a · daf3e6a
1 parent 47e5f8b
commit daf3e6a
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/lib/stringify.js b/lib/stringify.js
@@ -75,7 +75,12 @@ var stringify = function stringify(
     } else if (obj instanceof Date) {
         obj = serializeDate(obj);
     } else if (generateArrayPrefix === 'comma' && isArray(obj)) {
-        obj = obj.join(',');
+        obj = utils.maybeMap(obj, function (value) {
+            if (value instanceof Date) {
+                return serializeDate(value);
+            }
+            return value;
+        }).join(',');
     }
 
     if (obj === null) {

diff --git a/test/stringify.js b/test/stringify.js
@@ -595,6 +595,18 @@ test('stringify()', function (t) {
             'custom serializeDate function called'
         );
 
+        st.equal(
+            qs.stringify(
+                { a: [date] },
+                {
+                    serializeDate: function (d) { return d.getTime(); },
+                    arrayFormat: 'comma'
+                }
+            ),
+            'a=' + date.getTime(),
+            'works with arrayFormat comma'
+        );
+
         st.end();
     });