remove JSON conversion, explicitly convert buffers, booleans, and tim…

…estamps to their string equivalents
ljharb · Aug 5, 2014 · e473156 · e473156
1 parent a66f9c7
commit e473156
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 5 deletions.
diff --git a/lib/stringify.js b/lib/stringify.js
@@ -8,8 +8,16 @@ var internals = {};
 
 internals.stringify = function (obj, prefix) {
 
+    if (Buffer.isBuffer(obj)) {
+        obj = obj.toString();
+    }
+    else if (obj instanceof Date) {
+        obj = obj.toISOString();
+    }
+
     if (typeof obj === 'string' ||
-        typeof obj === 'number') {
+        typeof obj === 'number' ||
+        typeof obj === 'boolean') {
 
         return [prefix + '=' + encodeURIComponent(obj)];
     }
@@ -33,11 +41,10 @@ internals.stringify = function (obj, prefix) {
 module.exports = function (obj) {
 
     var keys = [];
-    var value = JSON.parse(JSON.stringify(obj));
 
-    for (var key in value) {
-        if (value.hasOwnProperty(key)) {
-            keys = keys.concat(internals.stringify(value[key], encodeURIComponent(key)));
+    for (var key in obj) {
+        if (obj.hasOwnProperty(key)) {
+            keys = keys.concat(internals.stringify(obj[key], encodeURIComponent(key)));
         }
     }
 

diff --git a/test/stringify.js b/test/stringify.js
@@ -104,4 +104,20 @@ describe('#stringify', function () {
         delete Object.prototype.crash;
         done();
     });
+
+    it('stringifies boolean values', function (done) {
+
+        expect(Qs.stringify({ a: true })).to.equal('a=true');
+        expect(Qs.stringify({ a: { b: true } })).to.equal('a[b]=true');
+        expect(Qs.stringify({ b: false })).to.equal('b=false');
+        expect(Qs.stringify({ b: { c: false } })).to.equal('b[c]=false');
+        done();
+    });
+
+    it('stringifies buffer values', function (done) {
+
+        expect(Qs.stringify({ a: new Buffer('test') })).to.equal('a=test');
+        expect(Qs.stringify({ a: { b: new Buffer('test') } })).to.equal('a[b]=test');
+        done();
+    });
 });