Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link to contributing document #183

Merged
merged 1 commit into from Dec 17, 2016
Merged

Conversation

elidoran
Copy link
Contributor

@elidoran elidoran commented Dec 17, 2016

The referenced document was moved into .github directory. This changes the link to point to its new location.

@elidoran
Copy link
Contributor Author

elidoran commented Dec 17, 2016

Travic CI failure is due to new linting seeing unnecessary escapes. I fixed those in a new PR #184.

Copy link
Owner

@ljharb ljharb left a comment

Actually, I was unaware this document was still here. Since qs is no longer part of hapi, this contributing guide no longer applies. Let's just remove it for now.

@elidoran
Copy link
Contributor Author

elidoran commented Dec 17, 2016

Would you like me to alter this PR for that or do you want to make your own?

@ljharb
Copy link
Owner

ljharb commented Dec 17, 2016

If you'd like to alter the PR that'd be great; I'm fine with either.

ljharb
ljharb approved these changes Dec 17, 2016
Copy link
Owner

@ljharb ljharb left a comment

Thanks!

@ljharb ljharb merged commit ec3bc8e into ljharb:master Dec 17, 2016
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants