Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove only the indices, not the square brackets #65

Closed
wants to merge 2 commits into from

Conversation

Dakuan
Copy link

@Dakuan Dakuan commented Jan 12, 2015

The {indices: false} feature isn't really doing what you would expect from the API. It's removing both the index number and the square brackets. This is a shame as the square brackets are expected to be there by a great many web technologies including PHP and Ruby On Rails.

@nlf
Copy link
Collaborator

nlf commented Jan 12, 2015

This would be a breaking change, instead let's add a new option brackets that will enable or disable brackets when indices === false and default it to false, that way the old behavior remains but can be explicitly overridden.

@nlf nlf self-assigned this Jan 12, 2015
@nlf nlf modified the milestones: 2.3.3, 2.4.0 Jan 12, 2015
@Dakuan
Copy link
Author

Dakuan commented Jan 14, 2015

@nlf had another suggestion: #46

@nlf
Copy link
Collaborator

nlf commented Feb 18, 2015

Superseded by #70, closing this

@nlf nlf closed this Feb 18, 2015
@nlf nlf removed this from the 2.4.0 milestone Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants