Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 3986 #76

Merged
merged 3 commits into from
May 21, 2015
Merged

RFC 3986 #76

merged 3 commits into from
May 21, 2015

Conversation

jamie-beck
Copy link
Contributor

This is a patch to get closer to the RFC 3986 specs as described here:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent

By following the RFC more closely the resulting string will be more cross language (programming) compatible.

To be more stringent in adhering to RFC 3986 (which reserves !, ', (, ), and *), even though these characters have no formalized URI delimiting uses.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent
Updating test so that it compares properly RFC 3986 encoded result.
@nlf
Copy link
Collaborator

nlf commented Mar 19, 2015

Nice, thanks

@nlf nlf self-assigned this Mar 19, 2015
@nlf nlf added this to the 3.0.0 milestone May 21, 2015
nlf added a commit that referenced this pull request May 21, 2015
@nlf nlf merged commit 3473201 into ljharb:master May 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants