[bfix] Calculates and logs rate-limit #8
Conversation
index.js
Outdated
| const getRateLimit = await rateLimit(); | ||
| console.log(getRateLimit.data.rate); | ||
| const writeOSSF = async () => { | ||
| repoOSSF[repository] = await output.slice(17).replace('\n', ''); |
There was a problem hiding this comment.
what's the magic 17 for?
also, this only replaces one newline; is that intended?
There was a problem hiding this comment.
The 17 slices the output string to get the Aggregate Score value for each repo from it. And similarly replacing the newlines iteratively is needed to get the score properly
There was a problem hiding this comment.
It might be clearer to use the actual string with .length rather than 17 :-)
Sounds good on the newlines - probably some text fixtures would make this clearer also.
There was a problem hiding this comment.
I did not understand, how can we splice the output string with .length?
|
I'm not sure why the |
|
Try |
Riyabelle25
changed the title
Riyabelle25
changed the title
|
@Riyabelle25 i rebased this but there's basically nothing left in it. Could you repurpose it to continue the rate limiting work? |
|
@ljharb apologies for the long gap of silence. Had end of term examinations followed by a long period of bothersome illness 😞 |
Solves #5
Calculates and logs Rate-Limit using the GitHub API, making use of async-await