Skip to content

Commit

Permalink
Adding keys during enumeration should not result in their appearance.
Browse files Browse the repository at this point in the history
  • Loading branch information
ljharb committed Dec 14, 2015
1 parent 00c0b36 commit 918d8b1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
7 changes: 2 additions & 5 deletions test/built-ins/object/entries/getter-adding-key.js
Expand Up @@ -2,7 +2,7 @@
// This code is governed by the BSD license found in the LICENSE file.

/*---
description: Object.entries sees a new element added by a getter that is hit during iteration
description: Object.entries does not see a new element added by a getter that is hit during iteration
es7id: pending
author: Jordan Harband
---*/
Expand All @@ -18,15 +18,12 @@ var bAddsC = {
var result = Object.entries(bAddsC);

assert.sameValue(Array.isArray(result), true, 'result is an array');
assert.sameValue(result.length, 3, 'result has 3 items');
assert.sameValue(result.length, 2, 'result has 2 items');

assert.sameValue(Array.isArray(result[0]), true, 'first entry is an array');
assert.sameValue(Array.isArray(result[1]), true, 'second entry is an array');
assert.sameValue(Array.isArray(result[2]), true, 'third entry is an array');

assert.sameValue(result[0][0], 'a', 'first entry has key "a"');
assert.sameValue(result[0][1], 'A', 'first entry has value "A"');
assert.sameValue(result[1][0], 'b', 'second entry has key "b"');
assert.sameValue(result[1][1], 'B', 'second entry has value "B"');
assert.sameValue(result[2][0], 'c', 'third entry has key "c"');
assert.sameValue(result[2][1], 'C', 'third entry has value "C"');
5 changes: 2 additions & 3 deletions test/built-ins/object/values/getter-adding-key.js
Expand Up @@ -2,7 +2,7 @@
// This code is governed by the BSD license found in the LICENSE file.

/*---
description: Object.values sees a new element added by a getter that is hit during iteration
description: Object.values does not see a new element added by a getter that is hit during iteration
es7id: pending
author: Jordan Harband
---*/
Expand All @@ -18,8 +18,7 @@ var bAddsC = {
var result = Object.values(bAddsC);

assert.sameValue(Array.isArray(result), true, 'result is an array');
assert.sameValue(result.length, 3, 'result has 3 items');
assert.sameValue(result.length, 2, 'result has 2 items');

assert.sameValue(result[0], 'A', 'first value is "A"');
assert.sameValue(result[1], 'B', 'second value is "B"');
assert.sameValue(result[2], 'C', 'third value is "C"');

0 comments on commit 918d8b1

Please sign in to comment.