Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validationMiddleware #80

Closed
ljlm0402 opened this issue Apr 9, 2021 · 0 comments
Closed

Fix validationMiddleware #80

ljlm0402 opened this issue Apr 9, 2021 · 0 comments
Assignees
Labels
Develop 👉 Develop ⚡ Feature Suggest an idea for this project

Comments

@ljlm0402
Copy link
Owner

ljlm0402 commented Apr 9, 2021

Motivation(새로운 기능 설명)

If the skipMissingProperties value of validation middleware is set to true, the corresponding function is not performed at all.

However, it is necessary to determine the req data based on dto, and verification of other req data is required.

Proposed Solution(기능을 통해 얻고자 하는 솔루션)

For example, it is composed of dto = email, password, but if the data of req.body is added as email, password, name, and name data is added, the corresponding verification must be done even if skipMissingProperties = true.

Alternatives(제안 된 솔루션이 더 나은 이유)

Additional Context(추가 사항)

@ljlm0402 ljlm0402 added ⚡ Feature Suggest an idea for this project Develop 👉 Develop 🛠 Refactoring labels Apr 9, 2021
@ljlm0402 ljlm0402 self-assigned this Apr 9, 2021
ljlm0402 added a commit that referenced this issue Apr 9, 2021
- Fix validationMiddleware #80
- Add whitelist, forbidNonWhitelisted in ValidatorOptions
@ljlm0402 ljlm0402 linked a pull request Apr 13, 2021 that will close this issue
3 tasks
@ljlm0402 ljlm0402 removed a link to a pull request Apr 18, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Develop 👉 Develop ⚡ Feature Suggest an idea for this project
Projects
None yet
Development

No branches or pull requests

1 participant