Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

Addon not working since last update of HA. Could you please fix this? #31

Closed
rucanunes opened this issue Dec 12, 2022 · 14 comments
Closed

Comments

@rucanunes
Copy link

Version of the custom_component

Configuration

Add your logs here.

Describe the bug

A clear and concise description of what the bug is.

Not working since last update of HA

Debug log


Unable to install package ourgroceries==1.5.0: ERROR: Cannot install ourgroceries==1.5.0 because these package versions have conflicting dependencies. ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts [notice] A new release of pip available: 22.3 -> 22.3.1 [notice] To update, run: pip install --upgrade pip

@Mucka911
Copy link

Mucka911 commented Dec 12, 2022

Hello getting same issue as well.

Integration error: ourgroceries - Requirements for ourgroceries not found: ['ourgroceries==1.5.0'].

Running version 1.5.0

@chicknlil
Copy link

chicknlil commented Dec 13, 2022

Same.

Logger: homeassistant.setup
Source: setup.py:202
First occurred: 7:08:50 PM (1 occurrences)
Last logged: 7:08:50 PM

Setup failed for custom integration ourgroceries: Requirements for ourgroceries not found: ['ourgroceries==1.5.0'].

@DataBitz
Copy link

Was broken initially after 2022.12.0 and beta but then was fixed after ha-our-groceries 1.5.0.
Seems to be broken again since 2022.12.2 or 2022.12.3.

@sandman98321
Copy link

I'm still on 11.x and am getting the same error.

@bschatzow
Copy link

bschatzow commented Dec 13, 2022

Still broken on 12.4 release.

Logger: homeassistant.util.package
Source: util/package.py:98
First occurred: 10:55:02 AM (6 occurrences)
Last logged: 11:10:03 AM

Unable to install package ourgroceries==1.5.0: ERROR: Cannot install ourgroceries==1.5.0 because these package versions have conflicting dependencies. ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts [notice] A new release of pip available: 22.3 -> 22.3.1 [notice] To update, run: pip install --upgrade pip

@frenck
Copy link

frenck commented Dec 13, 2022

The issue is caused by the pins here:

https://github.com/ljmerza/py-our-groceries/blob/32d6600fa602cd452dfd56a6836fe926f6646fa1/setup.py#L6-L7

    'aiohttp==3.8.3',
    'beautifulsoup4==4.11.1'

Packages/libraries should not pin strictly but instead, pin a minimal version or ping a range with a minimal and max version for subdependencies.

For example, is there a specific reason that library only works with aiohttp 3.8.3 and not with 3.8.1? Or why wouldn't it work with 3.7.x?

../Frenck

@frenck
Copy link

frenck commented Dec 13, 2022

Oh also noticed, the upstream library advertises itself as being compatible with Python >=3.5, which is impossible, as the requirements currently pinned as pointed out above, require at least Python 3.7.

@rucanunes
Copy link
Author

Is there a way to fix this issue?

@malaki86
Copy link

Just found out about Ourgroceries & the HA integration today. I was ripping out what's left of my hair trying to get it working in HA.

@frenck
Copy link

frenck commented Dec 13, 2022

Is there a way to fix this issue?

@rucanunes Yes, see my reply above.

If your question is: Can you fix it yourself? No, not without forking the library and custom integration and build your own.

@kovrom
Copy link

kovrom commented Dec 14, 2022

Same issue. Our Groceries 1.5.0 doesn't work with HA 2022.12.5. Happened previously with v 1.4.1 but was very quickly fixed by @ljmerza. He is a real mvp :)
Unable to install package ourgroceries==1.5.0: ERROR: Cannot install ourgroceries==1.5.0 because these package versions have conflicting dependencies. ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts [notice] A new release of pip available: 22.3 -> 22.3.1 [notice] To update, run: pip install --upgrade pip
Thank you

@ljmerza
Copy link
Owner

ljmerza commented Dec 14, 2022

that error message is supposed to tell you what package is conflicting. if it doesnt tell me not sure how to fix it. there's only two packages and they both match the HA version

@frenck
Copy link

frenck commented Dec 14, 2022

@ljmerza They don't and they should not match. They should provide a valid range, see also my explanation here:

#31 (comment)

As a general rule of thumb: Don't ever pin exact versions in libraries (unless the library itself has a hard requirement of some sort, which is not the case for this library at hand).

../Frenck

@ljmerza
Copy link
Owner

ljmerza commented Dec 14, 2022

okay should work again on v1.5.1

@ljmerza ljmerza closed this as completed Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants