Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handlers features from #238 removed duplicate calls fixes from #266 #289

Closed
danielcorreia96 opened this issue Feb 14, 2019 · 3 comments · Fixed by #290
Closed

Handlers features from #238 removed duplicate calls fixes from #266 #289

danielcorreia96 opened this issue Feb 14, 2019 · 3 comments · Fixed by #290
Assignees
Labels
bug Bugs, bug fixes, etc.

Comments

@danielcorreia96
Copy link
Contributor

Describe the bug
The PR that added boundary/velocity handlers (#238) removed the fixes to duplicate function calls.

To Reproduce
For example, check the history of GeneralOptimizer at https://github.com/ljvmiranda921/pyswarms/commits/master/pyswarms/single/general_optimizer.py

You can see that the handlers commit reverted the duplicate function call fixes (array np.inf initilization and duplicate call removal).

Expected behavior
Both features should exist at the same time.

Additional context
@ljvmiranda921, I'll try to make a PR to fix this (again) as soon as possible :)

@ljvmiranda921
Copy link
Owner

ljvmiranda921 commented Feb 14, 2019

Whoops, thanks for catching @danielcorreia96 !

@whzup , can you facilitate the review on the upcoming PR?

Would it be better to work on this branch since @whzup is introducing another fix to the handlers? So that I can just merge that one and make a patch release

If that sounds tricky, it's fine to just branch out from master

@danielcorreia96
Copy link
Contributor Author

I don't think working on top of an existing branch is a good idea: each branch should target a specific feature/problem 👍

@ljvmiranda921
Copy link
Owner

Thanks for this, @danielcorreia96 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs, bug fixes, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants