Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-fix duplicate cost function calls in optimize() #290

Merged
merged 1 commit into from Feb 14, 2019

Conversation

danielcorreia96
Copy link
Contributor

Description

The PR that added boundary/velocity handlers (#238) removed the fixes to duplicate function calls introduced in #266.

Related Issue

Resolves: #289

Motivation and Context

Both features should exist at the same time 馃憤

How Has This Been Tested?

Ran tests locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Owner

@ljvmiranda921 ljvmiranda921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, this was my bad

@ljvmiranda921 ljvmiranda921 merged commit 45880d0 into ljvmiranda921:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handlers features from #238 removed duplicate calls fixes from #266
2 participants