Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build removing usage of itkMultiplyByConstantImageFilter #4

Closed
jcfr opened this issue Aug 31, 2017 · 4 comments
Closed

Fix build removing usage of itkMultiplyByConstantImageFilter #4

jcfr opened this issue Aug 31, 2017 · 4 comments

Comments

@jcfr
Copy link
Contributor

jcfr commented Aug 31, 2017

Fix build error by updating code to use itkDisplacementFieldJacobianDeterminantFilter instead of itkMultiplyByConstantImageFilter.

The filter itkMultiplyByConstantImageFilter is deprecated and available only when building ITK with ITKV3_COMPATIBILITY set to 1 and this is NOT the case anymore in Slicer.

[ 50%] Building CXX object CLILASegmenter/CMakeFiles/LASegmenterLib.dir/LASegmenter.cxx.o
In file included from /tmp/LASegmenter/CLILASegmenter/LASegmenter.cxx:9:0:
/tmp/LASegmenter/CLILASegmenter/lib/utilities.hxx:30:46: fatal error: itkMultiplyByConstantImageFilter.h: No such file or directory
compilation terminated.
CLILASegmenter/CMakeFiles/LASegmenterLib.dir/build.make:68: recipe for target 'CLILASegmenter/CMakeFiles/LASegmenterLib.dir/LASegmenter.cxx.o' failed
make[2]: *** [CLILASegmenter/CMakeFiles/LASegmenterLib.dir/LASegmenter.cxx.o] Error 1
CMakeFiles/Makefile2:1089: recipe for target 'CLILASegmenter/CMakeFiles/LASegmenterLib.dir/all' failed
make[1]: *** [CLILASegmenter/CMakeFiles/LASegmenterLib.dir/all] Error 2
Makefile:162: recipe for target 'all' failed
make: *** [all] Error 2

Error similar to

@jcfr jcfr changed the title Remove usage of itkMultiplyByConstantImageFilter Fix build removing usage of itkMultiplyByConstantImageFilter Aug 31, 2017
@jcfr
Copy link
Contributor Author

jcfr commented Aug 31, 2017

Good news. This was fixed for LASegmenter by @blowekamp. See #3

@ljzhu ljzhu closed this as completed Oct 13, 2017
@ljzhu
Copy link
Owner

ljzhu commented Oct 13, 2017

@jcfr Hi JC, I am a bit confused. Based on the comment on Aug 31, it says the the issue was fixed. See #3. Could you let me know what else needs to be integrated? Thanks!

@ljzhu ljzhu reopened this Oct 13, 2017
@jcfr
Copy link
Contributor Author

jcfr commented Oct 13, 2017

It is indeed mentioned that it was fixed in the pull request #3 not in the master branch of your project. The fix will effectively be integrated by merging the changes instead of just closing the pull request.

For your convenience, I just rebased the PR#3 and created a new one.

To summarize, consider testing locally and then merging #5 and #6

@jcfr
Copy link
Contributor Author

jcfr commented Oct 13, 2017

Well done 👍

Closing. Fix integrated in f5837c1

@jcfr jcfr closed this as completed Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants