Skip to content
This repository has been archived by the owner on Dec 24, 2021. It is now read-only.

Create plugin from this project? #37

Closed
lk-geimfari opened this issue Feb 16, 2017 · 7 comments
Closed

Create plugin from this project? #37

lk-geimfari opened this issue Feb 16, 2017 · 7 comments

Comments

@lk-geimfari
Copy link
Owner

So, what do you thinks about it?

I want to create plugin for pytest that will provide fixtures.

@lk-geimfari
Copy link
Owner Author

lk-geimfari commented Feb 16, 2017

Something like this:

def test_username(ex):
    assert ex.USERNAME.match(username)

@lk-geimfari
Copy link
Owner Author

@the-zebulan @imgglasses @jhedlund79 @Tititesouris @blag What do you think?

@blag
Copy link
Contributor

blag commented Feb 16, 2017

I'm not familiar enough with PyTest to offer an informed opinion.

I just added the IPv6 regex from my Stack Overflow post, and I wrote a test script for it: http://pastebin.com/TKLfQUG0

Maybe that will help?

@imgerson
Copy link
Contributor

I'm on the same boat as @blag I don't know much of PyTest but can gladly look at it at some point this weekend and come back to you @lk-geimfari!

@lk-geimfari
Copy link
Owner Author

@blag It would be awesome if you create PR. Our current IPv6 regex does not work.

@lk-geimfari
Copy link
Owner Author

@imgglasses Okay. Thank you!

@blag
Copy link
Contributor

blag commented Feb 17, 2017

@lk-geimfari As I noted in PR #5, it needs to be compiled/matched with the re.VERBOSE | re.IGNORECASE | re.DOTALL options. PR #38 fixes that and adds all 479 of the tests from my test script.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants