Update for CF/IOOS Conventions #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5545879432Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
lkilcher
reviewed
Aug 29, 2023
| @@ -44,7 +44,7 @@ def read_nortek(filename, userdata=True, debug=False, do_checksum=False, | |||
| for handler in logging.root.handlers[:]: | |||
| logging.root.removeHandler(handler) | |||
| filepath = Path(filename) | |||
| logfile = filepath.with_suffix('.log') | |||
| logfile = filepath.with_suffix('.dolfyn.log') | |||
lkilcher
reviewed
Aug 29, 2023
There was a problem hiding this comment.
Did you check that the only thing that changed is the names?
There was a problem hiding this comment.
Yes, I verified the tests were just failing on those specific variables' attributes
|
@lkilcher Realized you never hit the check so this can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to dolfyn metadata to conform to CF/IOOS variable metadata conventions.