-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Updates #127
Various Updates #127
Conversation
jmcvey3
commented
Jan 25, 2024
•
edited
Loading
edited
- Add function to calculate TI with a given noise level
- Fixes bug where the provided noise level would not be subtracted from spectra
- Added ability to subtract noise from turbulence intensity and Doppler noise from dissipation rates
- Added ability to read dual profiling Nortek AD2CPs
Pull Request Test Coverage Report for Build 8990137750Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The only thing I'd suggest is try to keep the test-coverage higher.
Yep I'm working on the test file for the dual profile additions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a quick look through, looks great!