Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Updates #127

Merged
merged 35 commits into from
May 8, 2024
Merged

Various Updates #127

merged 35 commits into from
May 8, 2024

Conversation

jmcvey3
Copy link
Collaborator

@jmcvey3 jmcvey3 commented Jan 25, 2024

  1. Add function to calculate TI with a given noise level
  2. Fixes bug where the provided noise level would not be subtracted from spectra
  3. Added ability to subtract noise from turbulence intensity and Doppler noise from dissipation rates
  4. Added ability to read dual profiling Nortek AD2CPs

@coveralls
Copy link

coveralls commented Jan 25, 2024

Pull Request Test Coverage Report for Build 8990137750

Details

  • 260 of 293 (88.74%) changed or added relevant lines in 11 files are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.3%) to 89.054%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dolfyn/io/api.py 3 4 75.0%
dolfyn/tests/test_analysis.py 26 27 96.3%
dolfyn/tests/test_read_adp.py 4 5 80.0%
dolfyn/adv/turbulence.py 10 12 83.33%
dolfyn/io/base.py 62 64 96.88%
dolfyn/adp/turbulence.py 10 13 76.92%
dolfyn/io/nortek2.py 85 88 96.59%
dolfyn/velocity.py 26 30 86.67%
dolfyn/tools/psd.py 7 13 53.85%
dolfyn/io/nortek2_lib.py 26 36 72.22%
Files with Coverage Reduction New Missed Lines %
dolfyn/io/nortek2.py 1 92.69%
dolfyn/tools/psd.py 1 84.8%
dolfyn/tests/test_read_adp.py 1 80.28%
dolfyn/adp/turbulence.py 3 82.65%
Totals Coverage Status
Change from base Build 8177249776: 0.3%
Covered Lines: 5679
Relevant Lines: 6377

💛 - Coveralls

@jmcvey3 jmcvey3 changed the title Add TI function and fix noise subtraction Various Updates Feb 16, 2024
lkilcher
lkilcher previously approved these changes Mar 6, 2024
Copy link
Owner

@lkilcher lkilcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only thing I'd suggest is try to keep the test-coverage higher.

@jmcvey3
Copy link
Collaborator Author

jmcvey3 commented Mar 6, 2024

Looks good. The only thing I'd suggest is try to keep the test-coverage higher.

Yep I'm working on the test file for the dual profile additions

@jmcvey3 jmcvey3 requested a review from lkilcher March 13, 2024 19:28
Copy link
Owner

@lkilcher lkilcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick look through, looks great!

@jmcvey3 jmcvey3 merged commit fa25579 into lkilcher:master May 8, 2024
9 checks passed
@jmcvey3 jmcvey3 deleted the new_ti branch May 8, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants