Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fif2edf #114

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fif2edf #114

wants to merge 6 commits into from

Conversation

lkorczowski
Copy link
Owner

Issue

Fix

  • detect if channel is in uV or V and tag the specific unit for edf file.

More issue

  • still quite a few artifacts in timeseries.

@lkorczowski
Copy link
Owner Author

fif
image

edf
image

Comment on lines 88 to 94
for i in range(n_channels):
if np.median(np.abs(channels[i])) < 1e-3:
scale = 1e6
unit = 'uV'
else:
scale = 1
unit = 'V'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Micro modif that makes it better:
`
for i in range(n_channels):

        if np.median(np.abs(channels[i])) < 1e-5:

            scale = 1e9

            unit = 'nV'

        else : 

            if np.median(np.abs(channels[i])) < 1e-3:

                scale = 1e6

                unit = 'uV'

            else:

                scale = 1

                unit = 'V'

`
No longer the cut off saturating threshold ;)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants