Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for openSUSE #2

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Initial support for openSUSE #2

merged 2 commits into from
Jan 5, 2024

Conversation

tacerus
Copy link
Contributor

@tacerus tacerus commented Dec 31, 2023

This adds support for SUSE based distributions and ensures they use
packaged Python libraries instead of PIP.
With this patch, the formula will be usable for configuring Podman on openSUSE Tumbleweed.
On openSUSE Leap and SUSE Linux Enterprise, additional work outside
of this formula is needed, due to an incompatible version of podman-py, however basic support is added by replacing the boolean test with a variant compatible with Jinja 2.10.
Let me know if any changes are desired.

@tacerus tacerus requested a review from lkubb as a code owner December 31, 2023 03:36
Copy link
Owner

@lkubb lkubb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking the time to contribute! Happy to hear that people are using this. :)

Maybe you can address the two minor suggestions, otherwise I'm fine with the changes.

podman/package/install.sls Outdated Show resolved Hide resolved
podman/post-map.jinja Outdated Show resolved Hide resolved
podman/parameters/defaults.yaml Show resolved Hide resolved
FORMULA Show resolved Hide resolved
The boolean test was introduced in Jinja 2.11. Unfortunately, it is
not backported to openSUSE Leap 15.5, which ships Jinja 2.10.

Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
@tacerus
Copy link
Contributor Author

tacerus commented Dec 31, 2023

Thanks a lot for taking the time to contribute! Happy to hear that people are using this. :)

Thanks a lot for providing this, it's been incredibly useful! :)

This adds support for SUSE based distributions and ensures they use
packaged Python libraries instead of PIP.
Primary target of this patch is openSUSE Tumbleweed.

Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
@lkubb lkubb merged commit 9da1bf5 into lkubb:master Jan 5, 2024
1 check failed
@lkubb
Copy link
Owner

lkubb commented Jan 5, 2024

Thanks again for taking the time to contribute, hope you have a great 2024!

@tacerus
Copy link
Contributor Author

tacerus commented Jan 5, 2024

Thank you! You as well. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants