Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElasticModalViewController "not open" error #39

Closed
joelmbell opened this issue Feb 25, 2017 · 1 comment
Closed

ElasticModalViewController "not open" error #39

joelmbell opened this issue Feb 25, 2017 · 1 comment

Comments

@joelmbell
Copy link
Contributor

When trying to subclass ElasticModalViewController in my project I get the error:

"Cannot inherit from non-open class 'ElasticModalViewController' outside of its defining module.

This happens because I've pulled in ElasticTransition with cocoa pods and its in a different module.
joelmbell added a commit to joelmbell/ElasticTransition that referenced this issue Feb 25, 2017
@joelmbell
Fixing Bug lkzhao#39
49467f8 
Made ElasticModalViewController "open" so classes outside of its module
can subclass it
@joelmbell joelmbell changed the title ElasticModalViewController not "open" error ElasticModalViewController "not open" error Feb 25, 2017
lkzhao added a commit that referenced this issue Feb 25, 2017
@lkzhao
Merge pull request #40 from joelmbell/bugfix
d195981 
Fixing Bug #39
@codepushr
Copy link

Please update the Podfile! Either merge to swift3 or change pod branch to master. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joelmbell @codepushr