New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElasticModalViewController "not open" error #39

Closed
joelmbell opened this Issue Feb 25, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@joelmbell
Contributor

joelmbell commented Feb 25, 2017

When trying to subclass ElasticModalViewController in my project I get the error:

"Cannot inherit from non-open class 'ElasticModalViewController' outside of its defining module.

This happens because I've pulled in ElasticTransition with cocoa pods and its in a different module.

joelmbell added a commit to joelmbell/ElasticTransition that referenced this issue Feb 25, 2017

Fixing Bug #39
Made ElasticModalViewController "open" so classes outside of its module
can subclass it

@joelmbell joelmbell changed the title from ElasticModalViewController not "open" error to ElasticModalViewController "not open" error Feb 25, 2017

lkzhao added a commit that referenced this issue Feb 25, 2017

@joelmbell joelmbell closed this Feb 25, 2017

@codepushr

This comment has been minimized.

Show comment
Hide comment
@codepushr

codepushr Jun 29, 2017

Please update the Podfile! Either merge to swift3 or change pod branch to master. Thanks!

codepushr commented Jun 29, 2017

Please update the Podfile! Either merge to swift3 or change pod branch to master. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment