Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

attendance-management-angular-13 (JS-0323) Detected usage of the `any… #14

Merged
merged 3 commits into from
Jun 22, 2024

Conversation

llTheBlankll
Copy link
Owner

…` type

closes #13 by adding explicit type
feat(app): enhance authentication service and improve DTO imports

Update AuthService to include LoginToken alongside LoginDTO for improved type safety during login requests
Adjust return types within AuthService:
    Replace generic Observable responses with specific HttpResponse variants involving either LoginToken/StatusMessageResponse or just StatusMessageResponse.
Modify AttendanceLineChartService's getAttendanceLineChart()/getSectionAttendanceLineChart() methods by specifying LineChartDTO in their return types while also importing it explicitly along with HttpResponse
Remove redundant HttpClient import statement from TopHeaderComponent
Enhance StudentService by returning more precise types:
    Convert countStudentsBySection() method's return value to an observable emitting HttpResponse wrapping around a CountDTO object
    Transform getAllStudents() method's result into an observable yielding StudentPaging objects rather than an unspecific any type
Refactor TeacherService to fetch Teacher entities wrapped inside HttpResponse instances via the getTeacherByUserId() function
Standardize SectionService by consistently utilizing observables encapsulating HTTP responses across all methods (createSection(), updateSection(), etc.) and importing required DTO classes like StatusMessageResponse upfront
Ensure proper typing throughout remaining components such as AnnouncementsComponent, AdminDashboardComponent, TeacherDashboardComponent, and TeacherStudentsComponent

…` type

closes #13 by adding explicit type
feat(app): enhance authentication service and improve DTO imports

    Update AuthService to include LoginToken alongside LoginDTO for improved type safety during login requests
    Adjust return types within AuthService:
        Replace generic Observable responses with specific HttpResponse variants involving either LoginToken/StatusMessageResponse or just StatusMessageResponse.
    Modify AttendanceLineChartService's getAttendanceLineChart()/getSectionAttendanceLineChart() methods by specifying LineChartDTO in their return types while also importing it explicitly along with HttpResponse
    Remove redundant HttpClient import statement from TopHeaderComponent
    Enhance StudentService by returning more precise types:
        Convert countStudentsBySection() method's return value to an observable emitting HttpResponse wrapping around a CountDTO object
        Transform getAllStudents() method's result into an observable yielding StudentPaging objects rather than an unspecific any type
    Refactor TeacherService to fetch Teacher entities wrapped inside HttpResponse instances via the getTeacherByUserId() function
    Standardize SectionService by consistently utilizing observables encapsulating HTTP responses across all methods (createSection(), updateSection(), etc.) and importing required DTO classes like StatusMessageResponse upfront
    Ensure proper typing throughout remaining components such as AnnouncementsComponent, AdminDashboardComponent, TeacherDashboardComponent, and TeacherStudentsComponent
@llTheBlankll llTheBlankll self-assigned this Jun 22, 2024
Copy link

deepsource-io bot commented Jun 22, 2024

Here's the code health analysis summary for commits d7d9b98..b40cbde. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 10 occurences introduced
🎯 35 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

…` type

closes #13 by adding explicit type
feat(app): enhance authentication service and improve DTO imports

    Update AuthService to include LoginToken alongside LoginDTO for improved type safety during login requests
    Adjust return types within AuthService:
        Replace generic Observable responses with specific HttpResponse variants involving either LoginToken/StatusMessageResponse or just StatusMessageResponse.
    Modify AttendanceLineChartService's getAttendanceLineChart()/getSectionAttendanceLineChart() methods by specifying LineChartDTO in their return types while also importing it explicitly along with HttpResponse
    Remove redundant HttpClient import statement from TopHeaderComponent
    Enhance StudentService by returning more precise types:
        Convert countStudentsBySection() method's return value to an observable emitting HttpResponse wrapping around a CountDTO object
        Transform getAllStudents() method's result into an observable yielding StudentPaging objects rather than an unspecific any type
    Refactor TeacherService to fetch Teacher entities wrapped inside HttpResponse instances via the getTeacherByUserId() function
    Standardize SectionService by consistently utilizing observables encapsulating HTTP responses across all methods (createSection(), updateSection(), etc.) and importing required DTO classes like StatusMessageResponse upfront
    Ensure proper typing throughout remaining components such as AnnouncementsComponent, AdminDashboardComponent, TeacherDashboardComponent, and TeacherStudentsComponent
@llTheBlankll llTheBlankll merged commit 1d88f78 into main Jun 22, 2024
2 of 3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(JS-0323) Detected usage of the any type
1 participant