Two Factor Authentication

[ricknjacky]

• Enable/Disable TOTP
• Verification of TOTP entered
• Login Verification
• Unit Tests
• Documentation

[llaske]

I can't see the new Enable 2FA button on the user profile.
Is there something special to configure?

[ricknjacky]

Right, the settings is in the profile view (the one we access from top right corner menu) I rechecked, with this branch's file changes, It works.

^^Do test this at your end too and let me know if any issues occur here.

This is because the view is edit view and unlike password, we are restricting access to making changes to 2FA's state and enable/disable to the user only (account holder). This is the same logic in SSP-SERVER too.

[llaske]

Nice @ricknjacky. It works now.

Few remarks:

• Buttons alignment is not good. I think it should be margin-top: -63px for Enable button and margin-top: -68px for Disable button.
• Put 2FA tutorial popup before the created time popup. Popup should appear in the field order.
• Remove commented code here.
• Add a white space between Sugarizer and Server on the default service name here.

[llaske]

Thanks @ricknjacky for fixing PR feedback.

Two things left to do :

• Add a warning message when a teacher enable 2FA
• Update unit tests due to 2FA changes

[ricknjacky]

Thanks @ricknjacky for fixing PR feedback.

Two things left to do :

• Add a warning message when a teacher enable 2FA
• Update unit tests due to 2FA changes

Thank-you for the update!
Adding warning message asap.
As discussed, once this PR is merged into dev, I'll rebase and send in a new PR for tests.

[llaske]

Regarding unit test if it's not too complex it will be better to report your changes here so everything will be at the same place

[ricknjacky]

@llaske

Have added all the relevant test cases and they all pass successfully. Kindly review, Thanks.

[llaske]

Nice @ricknjacky.
Could you also update the Server Settings in README file to explain new parameters meaning in .INI file?

[ricknjacky]

@llaske done. Added relevant comments and information via comments too.

[llaske]

Good job @ricknjacky . Thanks for this contribution.