Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound don't restart in FoodChain activity #360

Closed
llaske opened this issue Jul 13, 2019 · 3 comments
Closed

Sound don't restart in FoodChain activity #360

llaske opened this issue Jul 13, 2019 · 3 comments
Labels
bug to be release Fixed, to be release
Milestone

Comments

@llaske
Copy link
Owner

llaske commented Jul 13, 2019

Step to reproduce:

  • Launch a new instance of FoodChain activity
  • Click to launch the build game
  • Cards appears and sounds are playing on each card
  • Do nothing and stop the activity
  • Reopen the FoodChain activity, the latest context is displayed
  • The first card appears but not sound is played and the second card never appears
@llaske llaske added the bug label Jul 13, 2019
@utkarsh-raj
Copy link
Contributor

After a bit of testing, I think that some API call is returning "en-GB" instead of "en" for the language code when the activity is reloaded. When we reload the activity, pause and play it, the error is gone the the activity functions as expected to.

I could identify two potential solutions. First, the en folder in audio can be safely renamed as en-GB, and I could test all the functions positively after this. Second, is to identify all the locale calls and see which is giving different codes, and maybe do a small hack to return the hardcoded "en" string instead to "en-GB".

Thoughts ?

Hemansh31 added a commit to Hemansh31/sugarizer that referenced this issue Feb 25, 2020
@Hemansh31
Copy link
Contributor

@llaske I have tried to resolve this issue and another issue that is when we go to home from a certain activity and then stop the activity and reopening the activity does not lead to home. (shown in GIF in PR #648

llaske added a commit that referenced this issue Mar 3, 2020
@llaske
Copy link
Owner Author

llaske commented Mar 3, 2020

Fixed in #648

@llaske llaske added the to be release Fixed, to be release label Mar 3, 2020
@llaske llaske added this to the v1.3 milestone Mar 11, 2020
@llaske llaske closed this as completed Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

3 participants