Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaving Sugarizer app without leaving current activity cause some activities to become empty #850

Closed
llaske opened this issue Sep 12, 2020 · 5 comments
Labels
bug to be release Fixed, to be release
Milestone

Comments

@llaske
Copy link
Owner

llaske commented Sep 12, 2020

It's possible to leave Sugarizer when an activity is still running: by closing the browser or by quitting the app.
In that case when the activity is relaunch, the content of the activity is empty.
Of course it's not a good idea for the user to leave activity on this way because it could lost its current work but having an empty context is not a good experience.

Peek 12-09-2020 22-32

It happens (at least) in Vote, Curriculum, Ebook Reader, Exerciser activities.

@llaske llaske added the bug label Sep 12, 2020
@llaske
Copy link
Owner Author

llaske commented Sep 12, 2020

@dhruvmisra, could you have a look on it? I guess it could be solve by saving the Journal instance when the context is load.

@dhruvmisra
Copy link
Contributor

Hmmm, is the journal entry modified right after accessing it from the datastore? I'm not sure why that would happen.

@llaske
Copy link
Owner Author

llaske commented Sep 16, 2020

I guess it's because the Journal entry is empty.
The Journal entry is created automatically by Sugar-web when a new instance is launched. So if the instance has no opportunity to save it - usually done on Stop event - the entry content is still empty.

@dhruvmisra
Copy link
Contributor

Oh right, it's a new instance. Okay I'll save the context right when the activity (new instance) is loaded.

@llaske
Copy link
Owner Author

llaske commented Sep 26, 2020

Fix for Ebook Reader, Vote and Curriculum in #851.
A specific issue has been opened for Exerciser here: llaske/ExerciserReact#100

@llaske llaske added the to be release Fixed, to be release label Sep 26, 2020
@llaske llaske added this to the v1.5 milestone Apr 26, 2021
@llaske llaske closed this as completed Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

2 participants