Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop playing a video change to fullscreen in VideoViewer activity #859

Closed
llaske opened this issue Sep 26, 2020 · 3 comments
Closed

Stop playing a video change to fullscreen in VideoViewer activity #859

llaske opened this issue Sep 26, 2020 · 3 comments
Milestone

Comments

@llaske
Copy link
Owner

llaske commented Sep 26, 2020

In VideoViewer activity, there is a button to switch to fullscreen mode.
On touch screen, when you play a video then touch the close button to go back to the main screen, the fullscreen mode is activated.
It happens on touch screen only.

Peek 26-09-2020 10-13

@Mrhb787
Copy link
Contributor

Mrhb787 commented Oct 7, 2020

Seems like there is a bug in script
I would like to work on this issue can you give me a headstart!

@llaske
Copy link
Owner Author

llaske commented Oct 7, 2020

Seems like there is a bug in script

I don't think it's related to a bug.
I think it's related to the UI: the close dialog button is located at the same place than the fullscreen button.
So the same touch raise two events: close then fullscreen. May be it's possible to stop the propagation of the close dialog event. Else it will be need to move the button.

@llaske
Copy link
Owner Author

llaske commented Oct 11, 2020

Fixed in #888

@llaske llaske added the to be release Fixed, to be release label Oct 11, 2020
@llaske llaske added this to the v1.5 milestone Apr 26, 2021
@llaske llaske closed this as completed Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants