Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for clock to show or hide minutes, AM hours, PM hours #903

Closed
jubonhomme opened this issue Dec 12, 2020 · 16 comments
Closed

Option for clock to show or hide minutes, AM hours, PM hours #903

jubonhomme opened this issue Dec 12, 2020 · 16 comments
Labels
enhancement to be release Fixed, to be release
Milestone

Comments

@jubonhomme
Copy link

Is it possible to add a button to show or hide the hours AM and PM hours and minutes with the corresponding colors?
Here is another example of an interactive clock that I find very complete.
http://www.informatique-enseignant.com/horloge-interactive-pour-apprendre-heure/
image

@llaske
Copy link
Owner

llaske commented Dec 13, 2020

Good idea!

@codescientist703
Copy link

hi @jubonhomme , Can I work on this if you are not working ? this looks like a nice feature to implement.

@jubonhomme
Copy link
Author

Yes you can...
I am not a programmer, just a teacher with some ideas and proposals
I used this old clock a few years ago but it only works with flash player...
And now that I know Sugarizer, I would really like to find these options on the clock.
Tank you !

@sarthak-g
Copy link
Contributor

Solved this in pull request #910

@llaske
Copy link
Owner

llaske commented Dec 26, 2020

Fixed in #910
@jubonhomme you could test the fix on the dev platform: https://dev.sugarizer.org

@llaske llaske added the to be release Fixed, to be release label Dec 26, 2020
@jubonhomme
Copy link
Author

Merci beaucoup pour ce travail et la réactivité !

Juste une petite remarque, l'affichage du nombre des minutes (60, 15 et 45) sur les côtés et en haut, est légèrement coupé sur l'affichage à 100%... il faudrait élargir un petit peu le cadre.
image

Sur mon écran ça passe bien si je zoom à partir de 130%
image

Ou si je sort du plein écran pour la fenêtre du navigateur.
image

Serait-il possible de séparer l'affichage des heures 24h et des minutes sur deux boutons différents.
Un bouton pour l'affichage des minutes
un autre bouton pour l'affichage des heures (13h/24h)

On ne travaille pas forcément les deux notions en même temps, je pense que ça serait plus clair de pouvoir afficher les deux indépendamment.

Merci encore !

@sarthak-g
Copy link
Contributor

@jubonhomme Can you try once after clearing all cookies.
In my laptop, it is showing correct with 100% zoom.

clock_am_pm_display

@llaske
Copy link
Owner

llaske commented Dec 27, 2020

I'm agree that may be we could add some pixel margin to the top. It seems specifically visible on Firefox.

Peek 27-12-2020 11-18

Regarding splitting options 12/24h and showing minutes, I'm usually not in favor to add too much buttons in the toolbar (to avoid a too complex UI). BTW you're right these features are not really related.

@sarthak-g could you split the feature in two different buttons?
The first one to display 24h hours (may be you could redraw the icon to do a switch between 12/24 instead of AM/PM).
The second one to display minutes.

@sarthak-g
Copy link
Contributor

sarthak-g commented Dec 27, 2020

@llaske I'm not able to reproduce first issue on firefox and chrome. Is I'm missing something?

clock_activity_screen.mp4

@jubonhomme
Copy link
Author

jubonhomme commented Dec 27, 2020

I tested with linux (Ubuntu 20.04) Firefox and Chrome, always the same issue.

But it's Ok with win10 for Chrome and Firefox...

It's only with Ubuntu

clock.mp4

@sarthak-g
Copy link
Contributor

Thanks @jubonhomme for confirming.
I tried with Ubuntu 19.04 but not able to reproduce the issue. May be it's only there in 20.04
Although I tried to solve it in #915

@llaske
Copy link
Owner

llaske commented Dec 27, 2020

I tested with linux (Ubuntu 20.04) Firefox and Chrome, always the same issue.
It's only with Ubuntu

More a resolution issue because my test above was on Ubuntu 20.04 with Firefox.

@jubonhomme
Copy link
Author

It happens only when the window is full screen... it's strange

A new video capture with chrome, if that can help you
https://user-images.githubusercontent.com/29262866/103181121-c3625980-489d-11eb-8c1d-89bc5c28cc7f.mp4

@sarthak-g
Copy link
Contributor

Tried with firefox on 20.04 but not able to reproduce it. I reduced clock radius when displaying minutes in #915
Hope it resolves the issue.

@llaske
Copy link
Owner

llaske commented Dec 30, 2020

@jubonhomme the new version is online on https://dev.sugarizer.org
Please test the new feature (split of 24h/minutes buttons) and fix on size.

@jubonhomme
Copy link
Author

jubonhomme commented Dec 30, 2020

Perfect !
Thanks to all contributors.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

4 participants