Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a full 24h mode in Clock activity #921

Closed
llaske opened this issue Jan 13, 2021 · 4 comments
Closed

Implement a full 24h mode in Clock activity #921

llaske opened this issue Jan 13, 2021 · 4 comments
Labels
enhancement to be release Fixed, to be release
Milestone

Comments

@llaske
Copy link
Owner

llaske commented Jan 13, 2021

A new feature #903 of Clock activity added a 24h mode to display 24h value for hours.

The idea is to improve this mode to:

  • Use this settings for digits too
  • Change background of the clock for PM hours (may be from white to black)
  • Allow to pass to AM and PM when rotating the clock arrows
  • Ask questions for AM and PM in play mode

Peek 13-01-2021 22-14

@saurabhhere
Copy link
Contributor

For PM hours, do we need something like this?

Screenshot from 2021-01-21 18-38-26

@llaske
Copy link
Owner Author

llaske commented Jan 21, 2021

That's the idea.
Did you change the hours colors? It seems brighter than the AM version. I think it's better if colors are the same in AM/PM mode.

@saurabhhere
Copy link
Contributor

No, I haven't updated the hours colors. Those are the same as before. Please have a look at #923

@llaske
Copy link
Owner Author

llaske commented Feb 13, 2021

Fixed in #923

@llaske llaske added the to be release Fixed, to be release label Feb 13, 2021
@llaske llaske added this to the v1.5 milestone Apr 26, 2021
@llaske llaske closed this as completed Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

2 participants