Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #69 #106 Solution #112

Closed
wants to merge 2 commits into from

Conversation

rajeevravindran
Copy link
Contributor

@davelab6 Issue #69 Red Face is rendered on the initial position. Becomes gray after moving.
screenshot_20170313_155006

@mikklfr Issue #106 Changed padding to 50px to accommodate the close button on lower res phones.

Reduced the padding of .toolbar to accomadate the close button.
Draws a red face on the initial position to draw the user's attention
@llaske
Copy link
Owner

llaske commented Mar 14, 2017

It solve the issue most of the times but sometimes the face stay grey.
Could you test on your side ?

@rajeevravindran
Copy link
Contributor Author

Tested extensively @llaske. Can you help me point where exactly it starts with grey instead of the red face?

@llaske
Copy link
Owner

llaske commented Mar 17, 2017

Merged in dev branch on eebc7db
Not a good idea to commit two issues together, I had to reverse back the #106 fix in 8be97ed
Plus, you can't change the size of the close button in the sugar-css, it's a major impact on all Sugarizer activities. @mikklfr could you check this fix ?

@llaske llaske closed this Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants