Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes made as specified in #192 #193

Closed
wants to merge 5 commits into from
Closed

Conversation

hardikmodi1
Copy link

changes made as specified in #192

  1. Score and popup should be responsive
  2. Both score and popup are now responsive.
  3. Text must be localized to adapt the current language
  4. Language support added
  5. Score during the game
  6. I have removed the score from the game and it can be seen only at the end of the game.
  7. Precision in accuracy
  8. It is neccessary to add the precision as such a big number is not at all good to see for user thus two decimal point precision added.

@llaske
Copy link
Owner

llaske commented Mar 5, 2018

  • There is still issues on responsive. See for example this screen capture (popup not centered, scrollbar on the left of screen).

image

  • The language support is hard coded, should use the webl10n library instead as mentioned earlier.

  • Please clean commented lines and trace log in the source code.

  • You must not include a fix for Speak activity into the same PR than a fix of Abecedarium if both are unrelated.

@hardikmodi1
Copy link
Author

webl10n library is used and language is no longer hardcoded.
all commented lines and trace logs are removed.

@hardikmodi1
Copy link
Author

score popup is now much more responsive.

@llaske
Copy link
Owner

llaske commented Dec 22, 2019

No more pertinent

@llaske llaske closed this Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants