Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of play in Flip activity #234

Merged
merged 7 commits into from
Nov 14, 2018
Merged

Add number of play in Flip activity #234

merged 7 commits into from
Nov 14, 2018

Conversation

FreddieN
Copy link
Contributor

Fixes #216
There is now a turn counter in the flip activity, similar to the generation count in the Game of Life activity. There is also a coloured skill indicator to let the player know how well they are doing. See below:

demo
demo

Let me know if any issues :)

@llaske
Copy link
Owner

llaske commented Nov 12, 2018

Nice start. Few remarks:

  • The "Turn" string should be localized, you need to include localization (see https://github.com/llaske/sugarizer/blob/dev/docs/tutorial_step5.md)
  • The "Turn" string is not responsive: its size should depend of the window size
  • The counter is not stored in the datastore so it restart to 1 when the activity is relaunched from the Journal
  • Good idea to change line color depending of number of turn. BTW it should be also dependent of board size: it's easier to flip all board if size is smaller

@FreddieN
Copy link
Contributor Author

Turn string is now localized:
demo
It is also now responsive to suit the screen height. The counter is also stored in the datastore so when opening from the journal the user's session is restored. I've adjusted the indicator to adjust to the board's difficulty.
Let me know if you want anything else changed.

@llaske
Copy link
Owner

llaske commented Nov 13, 2018

It's better.
BTW there is still two issues:

  • The line color is green when the game is restored from the Journal, whatever number is,
  • When reloaded from Journal the board size is changed (it's smaller) and not optimal.

@FreddieN
Copy link
Contributor Author

I have fixed the issue with the green indicator, I am unable to replicate the issue with the board size being smaller? Could you send a screenshot replicating the issue?

@FreddieN
Copy link
Contributor Author

I think you might have meant this button:
demo
I have now updated the game to store this in the journal.

@llaske
Copy link
Owner

llaske commented Nov 14, 2018

It works now. Great job.

@llaske llaske merged commit 69eb5a0 into llaske:dev Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants