Added ScreenSaver for sugarizer

[crusher95]

No description provided.

[davelab6]

@crusher95 please rebase your branch and fixup the 2nd commit into a single commit :)

https://www.google.com/search?q=git+rebase+interactive

[davelab6]

What is the license for js/screensaver.jpg? I think this is an image subject to restrictive copyrights from threadless.com

[davelab6]

Why is css/styles.css mod from 100644 → 100755?

The only changes to css/styles.css relevant to this PR seem to be

#screen{
    z-index: 100000;
}

The code-style can be improved (adding a space before {)

@llaske do you have a code style linter?

[davelab6]

It is good practice to have a final blank newline at the end of every text line to prevent concatenated output merging the last and first lines of files.

[davelab6]

Please add a blank new line to the end of the file

[davelab6]

why is this changed?

[davelab6]

965a5f8 adds a new gif, but what is the license for this? Where is it from?

[llaske]

Don't work here. image is null line 12 of the screensaver.js script both on Chrome and Firefox.
Plus I'm not at all a big fan of the idea of a screen saver. It has no sense on devices where screen saving is already handle (tablet, smartphone and PC) and I don't see the interest of a screen saver in a web browser.

[crusher95]

Hi,

Yes point accepted (y) . Is there any other issue that you could assign me
or suggest me for sugarizer?

Thanking You,
Utkarsh Dhawan
(Developer/Student)

Note:Please Consider The environment before printing.

On Sun, Apr 3, 2016 at 2:16 PM, Lionel LASKE notifications@github.com
wrote:

Don't work here. image is null line 12 of the screensaver.js script both
on Chrome and Firefox.
Plus I'm not at all a big fan of the idea of a screen saver. It has no
sense on devices where screen saving is already handle (tablet, smartphone
and PC) and I don't see the interest of a screen saver in a web browser.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#46 (comment)

[davelab6]

I think this is the reason: It is fun! :)

[llaske]

Hi Utkarsh, I don't have any issue to assign, except if you find one in testing.
BTW, if you've got some time, may be you could try to port some existing activities. Why not FractionBounce ? http://activities.sugarlabs.org/en/sugar/addon/4488

[crusher95]

Hi,

An interesting activity indeed. I am on it (y)

Thanking You,
Utkarsh Dhawan
(Developer/Student)

Note:Please Consider The environment before printing.

On Tue, Apr 5, 2016 at 1:23 AM, Lionel LASKE notifications@github.com
wrote:

Closed #46 #46.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#46 (comment)