-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Activity Idea: Planets Activity #711
Conversation
This includes the images, icons, and css
showInfo requires double clicking to work; Now it only requires one time click
Very cool idea and very good start 👍 Do you use a portable 3D library? Mean that could work on Chrome/Firefox/Safari/Android/iOS? An UI suggestion: may be you could use a black background on the home page. Plan a smartphone mode too (fullscreen button in the toolbar), it's now a pre-requisite for new activities. Can't wait to see the final result. |
I used Three.js library, and base on my research, I think it's portable. In this latest commit, I made the activity more responsive and I've also added a fullscreen mode. The home page's background should also be black (it is much nicer). |
Nice. Few suggestion:
|
This should fix the error in the console. Also, I've added the back button functionality and included planet names in the planet list. The rotation & info button should now able to be selected/unselected.
There's a bug where the planet rotation renders the previous animation on top of one another, thus giving the illusion where the rotation goes faster and faster. I've added a fix where the rotation animation is cancelled when back button was clicked.
@llaske I've fixed the console error and added the the suggested enhancement. I have a question regarding adding the relative position/size of planets. Did you mean something like this: |
@AndreaGon yes, exactly. BTW, look like some files are missing in your last commit. |
I've added the planet position and size in this latest commit. This should also fix the error message on the console. |
Very nice. Few remarks:
|
Upload tutorial.js
Upload bootstrap, jquery, and locale.ini
I've included the tutorial and localization. The back button should be fixed as well :) |
Nice. The Back button is now here. Few remarks:
|
When user clicks the planets in planet pos view, the explore view should appear
The rectangles (div tags) serve as hit boxes for smaller planets
I've added the enhancements in these commits. The margin on the left is also fixed. It wasn't caused by the back button, but it's because I tried putting the list view in the middle. Let me know what you think! |
This should fix the issue. When switching to touchscreen mode, the browser needs to be refreshed for it to detect whether it is in touchscreen mode or not. Thoughts? |
Work very nice now. Just found another small issue (not related to touch):
|
The same thing also happens to rotation button. This should fix it
I've fixed the issue in this commit. The same thing happens to rotation button, so I also fixed it. |
Good. I've tried to localize it here but it don't works because it seems that the |
The localization issue should now be fixed. I also did the same thing for the planet position view. |
The extra list view should now be removed. As for the list view in Safari, I made some changes on the CSS file as well. Let me know if the issue still persist. |
Works very well now on all platforms. Thanks a lot to add this beautiful activity. |
I've created a new possible activity for Sugarizer. Planets Activity ver. 1 offers a 3D model of the solar system planets, which allows students to take a closer look at them. This would hopefully help them appreciate and learn more about the Solar System's planets. As always, let me know what you think!