Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve responsivity and some styling change in Calculator #988

Closed
wants to merge 4 commits into from

Conversation

amanyadav777
Copy link

Fixes #982 and also improve some styling.

image
image
image

Please review my work.

@llaske
Copy link
Owner

llaske commented Mar 3, 2022

#982 is already fixed.
If you want to propose an improvement please first open an issue an explain what sort of improvement you propose. So we could discuss about it before the PR.

@llaske
Copy link
Owner

llaske commented Mar 5, 2022

The dimension you mention is not realistic. I don't think it's interesting to add/update the media query for that.
Regarding resizing of result square I think it's better to keep always the same thing, it's easier to understand for children.

@amanyadav777
Copy link
Author

amanyadav777 commented Mar 5, 2022

Okay sir.

@llaske llaske closed this Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants