Add mypy checks

schedule/forms.py

@@ -1,3 +1,4 @@
+from typing import List, Any
 from django import forms
 from django.utils.translation import gettext_lazy as _
 
@@ -43,6 +44,6 @@ class Meta:
 
 class EventAdminForm(forms.ModelForm):
     class Meta:
-        exclude = []
+        exclude: List[Any] = []
         model = Event
         widgets = {"color_event": ColorInput}

schedule/models/calendars.py

@@ -183,7 +183,7 @@ def get_absolute_url(self):
 
 class CalendarRelationManager(models.Manager):
     def create_relation(
-        self, calendar, content_object, distinction="", inheritable=True
+        self, calendar, content_object, distinction: str = "", inheritable: bool = True
     ):
         """
         Creates a relation between calendar and content_object.

schedule/models/events.py

@@ -115,7 +115,7 @@ def hours(self):
     def get_absolute_url(self):
         return reverse("event", args=[self.id])
 
-    def get_occurrences(self, start, end, clear_prefetch=True):
+    def get_occurrences(self, start: datetime.datetime, end: datetime.datetime, clear_prefetch: bool = True):
         """
         >>> rule = Rule(frequency = "MONTHLY", name = "Monthly")
         >>> rule.save()
@@ -206,7 +206,7 @@ def _create_occurrence(self, start, end=None):
             event=self, start=start, end=end, original_start=start, original_end=end
         )
 
-    def get_occurrence(self, date):
+    def get_occurrence(self, date: datetime.datetime):
         use_naive = timezone.is_naive(date)
         tzinfo = timezone.utc
         if timezone.is_naive(date):
@@ -229,7 +229,7 @@ def get_occurrence(self, date):
                     next_occurrence = timezone.make_naive(next_occurrence, tzinfo)
                 return self._create_occurrence(next_occurrence)
 
-    def _get_occurrence_list(self, start, end):
+    def _get_occurrence_list(self, start: datetime.datetime, end: datetime.datetime):
         """
         Returns a list of occurrences that fall completely or partially inside
         the timespan defined by start (inclusive) and end (exclusive)
@@ -474,7 +474,7 @@ class EventRelationManager(models.Manager):
     #         eventrelation__event = event
     #     )
 
-    def get_events_for_object(self, content_object, distinction="", inherit=True):
+    def get_events_for_object(self, content_object, distinction: str = "", inherit: bool = True):
         """
         returns a queryset full of events, that relate to the object through, the
         distinction
@@ -604,12 +604,11 @@ def __init__(self, *args, **kwargs):
         if not self.description and self.event_id:
             self.description = self.event.description
 
+    @property
     def moved(self):
         return self.original_start != self.start or self.original_end != self.end
 
-    moved = property(moved)
-
-    def move(self, new_start, new_end):
+    def move(self, new_start: datetime.datetime, new_end: datetime.datetime):
         self.start = new_start
         self.end = new_end
         self.save()

schedule/periods.py

@@ -117,7 +117,7 @@ def get_persisted_occurrences(self):
             )
             return self._persisted_occurrences
 
-    def classify_occurrence(self, occurrence):
+    def classify_occurrence(self, occurrence: Occurrence):
         if occurrence.cancelled and not SHOW_CANCELLED_OCCURRENCES:
             return
         if occurrence.start > self.end or occurrence.end < self.start:
@@ -152,12 +152,12 @@ def get_occurrences(self):
     def has_occurrences(self):
         return any(self.classify_occurrence(o) for o in self.occurrences)
 
-    def get_time_slot(self, start, end):
+    def get_time_slot(self, start: datetime.datetime, end: datetime.datetime):
         if start >= self.start and end <= self.end:
             return Period(self.events, start, end, tzinfo=self.tzinfo)
         return Period([], start, end, tzinfo=self.tzinfo)
 
-    def create_sub_period(self, cls, start=None, tzinfo=None):
+    def create_sub_period(self, cls, start: datetime.datetime = None, tzinfo=None):
         if tzinfo is None:
             tzinfo = self.tzinfo
         start = start or self.start

tox.ini

@@ -1,20 +1,18 @@
 [tox]
 envlist =
     lint
-    django22
+    mypy
     django31
     django32
-    djangomain
 
 [testenv]
 commands = {envpython} -Wa -b -m coverage run -m django test --settings=tests.settings
 deps =
-    django22: Django>=2.2,<2.3
     django31: Django~=3.1.0
     django32: Django~=3.2.0
-    djangomain: https://github.com/django/django/archive/main.tar.gz
     coverage
 
+
 [testenv:lint]
 basepython = python3
 commands =
@@ -27,3 +25,13 @@ deps =
     black
     flake8
     isort>=5.0.2
+
+
+[testenv:mypy]
+basepython = python3
+commands =
+    mypy schedule
+deps =
+    types-python-dateutil
+    types-pytz
+    mypy