Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front-end design improvements #357

Merged
merged 4 commits into from
Nov 3, 2022
Merged

Front-end design improvements #357

merged 4 commits into from
Nov 3, 2022

Conversation

lewislarsen
Copy link
Contributor

@lewislarsen lewislarsen commented Oct 30, 2022

I spent some time today to try and improve the design of the front end of LLDAP.

List of improvements that I can recall:

  • Added colour to required asterisks
  • Added padding to the footer
  • Added bootstrap class to select elements
  • Added various icons to buttons
  • Fixed various button layouts
  • Reworded some messages
  • Moved around some form elements

Fixes #12

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #357 (4b3e2e4) into main (e0c0efc) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 4b3e2e4 differs from pull request most recent head f09acf1. Consider uploading reports for the commit f09acf1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   71.77%   71.78%   +0.01%     
==========================================
  Files          32       32              
  Lines        8020     8020              
==========================================
+ Hits         5756     5757       +1     
+ Misses       2264     2263       -1     

@nitnelave
Copy link
Member

Thanks for the PR! The changes are nice.
I fixed the formatting in the top commit of https://github.com/nitnelave/lldap/tree/pr357, feel free to add it to your PR to make the checks pass.
I suspect a lot of the diffs came down to different editor configurations and the fact that HTML macros are not supported by the linter, I had to fix things by hand.

@nitnelave
Copy link
Member

Sorry, it seems that the formatting is still wrong, did you apply my patch?

@lewislarsen
Copy link
Contributor Author

Sorry, it seems that the formatting is still wrong, did you apply my patch?

Hadn't had my coffee yet, fixed! :)

@nitnelave nitnelave merged commit ba0dc33 into lldap:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve looks
2 participants