Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement password reset via LDAP #73

Merged
merged 5 commits into from
Oct 28, 2021
Merged

Implement password reset via LDAP #73

merged 5 commits into from
Oct 28, 2021

Conversation

nitnelave
Copy link
Member

This adds support for other systems to modify a user's password, for instance Authelia.

In addition, this adds a few missing LDAP functions required for a proper LDAP server, such as rootDSE request handling.

This is in preparation of supporting the password change message, since
this is from the Extended Operations that is not available in the simple
ServerOp.
This is the message that broadcasts the capabilities of the server,
including the supported extensions.
This allows other systems (e.g. Authelia) to reset passwords for users.
@nitnelave
Copy link
Member Author

Fixes #73

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #73 (0f8f929) into main (438ac28) will increase coverage by 2.17%.
The diff coverage is 72.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   69.50%   71.67%   +2.17%     
==========================================
  Files          13       13              
  Lines        2410     2690     +280     
==========================================
+ Hits         1675     1928     +253     
- Misses        735      762      +27     
Impacted Files Coverage Δ
server/src/infra/ldap_handler.rs 78.26% <72.46%> (+4.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438ac28...0f8f929. Read the comment docs.

@nitnelave nitnelave merged commit 43ffeca into main Oct 28, 2021
@nitnelave nitnelave deleted the password branch October 28, 2021 16:20
@nitnelave nitnelave added this to In progress in V1 via automation Oct 28, 2021
@nitnelave nitnelave moved this from In progress to Done in V1 Oct 29, 2021
@JaneJeon
Copy link

Oh, so does it mean that this is now outdated? https://github.com/nitnelave/lldap/blob/main/example_configs/authelia_config.yml#L10

@nitnelave
Copy link
Member Author

Yes! Feel free to open a PR to fix that, otherwise I'll do it when I have time.

@nitnelave
Copy link
Member Author

Added in #91

@nitnelave nitnelave removed this from Done in V1 Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants