Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD rc.d service script #883

Merged
merged 9 commits into from Apr 22, 2024
Merged

FreeBSD rc.d service script #883

merged 9 commits into from Apr 22, 2024

Conversation

n-connect
Copy link
Contributor

@n-connect n-connect commented Mar 28, 2024

Follow-up after closing PR #856 to have this service script independently. Manual/local lldap FreeBSD build available here

The script in its actual form takes into consideration, that lldap release has a complete structure:

  • app subdir for web content,
  • possible data subdir for other elements
  • and it expects the above sudirs to be in the same folder as the main lldap binary.

Use:

  • extract (the future) FreeBSD release package into /usr/local/ -> so your files will be under /usr/local/lldap_server/
  • save/copy this rc.d script file into /usr/local/etc/rc.d/
  • finally cat lldap_enable=YES >> /etc/rc.conf
  • the service script set to run the lldap server as "www" user - make sure the whole lldap_server directory is accessible/runnable by "www". Simplest to run chown -R www:www /usr/local/lldap_server

Note:
When ldap will accept config file parameter speficying the web content dir, this file need to be updated as well.

An rc.d service script
@nitnelave
Copy link
Member

Sorry for the late review.

I feel that all of the comments in this PR (assumptions, how-to and so on) should be in that file as comments. WDYT?

@n-connect
Copy link
Contributor Author

Sorry for the late review.

No problem, just looking the almost happened stuff around xz noone should do do changes just for the sake of speed.

I feel that all of the comments in this PR (assumptions, how-to and so on) should be in that file as comments. WDYT?

Could be, or we can put into the PR detailed description. Both good from my side. If the other things works out we can remove it later.

@nitnelave
Copy link
Member

I just think that most people are going to look at the file, not the PR, and will miss the assumptions. It'll be more discoverable to include it in the file itself.

Adding the below into the script too

Use:
extract (the future) FreeBSD release package into /usr/local/ -> so your files will be under /usr/local/lldap_server/
save/copy this rc.d script file into /usr/local/etc/rc.d/
finally cat lldap_enable=YES >> /etc/rc.conf
the service script set to run the lldap server as "www" user - make sure the whole lldap_server directory is accessible/runnable by "www". Simplest to run chown -R www:www /usr/local/lldap_server
@n-connect
Copy link
Contributor Author

I just think that most people are going to look at the file, not the PR, and will miss the assumptions. It'll be more discoverable to include it in the file itself.

Yepp, done - check it out both the PR description and the rc.d file has the info

example_configs/lldap Outdated Show resolved Hide resolved
@nitnelave
Copy link
Member

Sorry for the delay in reviewing! Life got in the way

@n-connect
Copy link
Contributor Author

Sorry for the delay in reviewing! Life got in the way

No worries.
I'm planning some other PR's to raise around let be the web artifact its own configurable http_root directory...

@nitnelave
Copy link
Member

Looks good! Can you add a link in the readme? Maybe the installation section.

@n-connect
Copy link
Contributor Author

Looks good! Can you add a link in the readme? Maybe the installation section.

It's there, check it

README.md Outdated Show resolved Hide resolved
@nitnelave nitnelave merged commit a978814 into lldap:main Apr 22, 2024
13 of 15 checks passed
@nitnelave
Copy link
Member

Thanks a lot, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants