Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Compose update #892

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Docker Compose update #892

wants to merge 2 commits into from

Conversation

bsncubed
Copy link

@bsncubed bsncubed commented Apr 6, 2024

Hi, I updated the docker compose part of the README file to include SMTP environment variables.

@bsncubed bsncubed requested a review from nitnelave as a code owner April 6, 2024 21:18
# - LLDAP_SMTP_OPTIONS__ENABLE_PASSWORD_RESET=true
# - LLDAP_SMTP_OPTIONS__SERVER=smtp.example.com
# - LLDAP_SMTP_OPTIONS__PORT=465 #Check your smtp providor's documentation for this setting
# - LLDAP_SMTP_OPTIONS__SMTP_ENCRYPTION=TLS #How the connection is encrypted, either "NONE" (no encryption), "TLS" or "STARTTLS".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should expand a bit on this bit of config, it's often confusing due to the wrong names used in email. SMTP settings usually list "TLS" when they mean STARTTLS, and then SSL means TLS.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good idea. I'll have a go at it over the next few days. Should it be in the main readme, or a new file in the docs folder?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the main readme, and in the config template at the top level

Added SMTP environment variables to the docker compose configuration
Fixed spelling
@nitnelave nitnelave added the needs-work The PR needs work before getting merged label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work The PR needs work before getting merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants