Skip to content

Commit

Permalink
coverity: change a bit the annotations
Browse files Browse the repository at this point in the history
We want coverity to ignore those errors. It doesn't seem to be the case.
  • Loading branch information
vincentbernat committed Apr 8, 2014
1 parent b64a011 commit 87dfd17
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
8 changes: 4 additions & 4 deletions src/client/lldpcli.c
Original file line number Diff line number Diff line change
Expand Up @@ -473,8 +473,8 @@ main(int argc, char *argv[])

/* Process file inputs */
while (gotinputs && !TAILQ_EMPTY(&inputs)) {
/* TAILQ_REMOVE does the right thing */
/* coverity[use_after_free] */
/* coverity[use_after_free]
TAILQ_REMOVE does the right thing */
struct input *first = TAILQ_FIRST(&inputs);
log_debug("lldpctl", "process: %s", first->name);
FILE *file = fopen(first->name, "r");
Expand Down Expand Up @@ -556,8 +556,8 @@ main(int argc, char *argv[])

end:
while (!TAILQ_EMPTY(&inputs)) {
/* TAILQ_REMOVE does the right thing */
/* coverity[use_after_free] */
/* coverity[use_after_free]
TAILQ_REMOVE does the right thing */
struct input *first = TAILQ_FIRST(&inputs);
TAILQ_REMOVE(&inputs, first, next);
free(first->name);
Expand Down
4 changes: 2 additions & 2 deletions src/daemon/event.c
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,8 @@ levent_ctl_accept(evutil_socket_t fd, short what, void *arg)
client);
bufferevent_enable(client->bev, EV_READ | EV_WRITE);
log_debug("event", "new client accepted");
/* s has been saved by bufferevent_socket_new */
/* coverity[leaked_handle] */
/* coverity[leaked_handle]
s has been saved by bufferevent_socket_new */
return;
accept_failed:
levent_ctl_free_client(client);
Expand Down
4 changes: 2 additions & 2 deletions src/daemon/interfaces-linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -807,8 +807,8 @@ interfaces_update(struct lldpd *cfg)
}
if (levent_iface_subscribe(cfg, s) == -1)
close(s);
/* s has been saved by levent_iface_subscribe */
/* coverity[leaked_handle] */
/* coverity[leaked_handle]
s has been saved by levent_iface_subscribe */
}

end:
Expand Down
8 changes: 4 additions & 4 deletions src/daemon/lldpd.c
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,8 @@ lldpd_reset_timer(struct lldpd *cfg)
size_t output_len;
char save[offsetof(struct lldpd_port, p_id_subtype)];
memcpy(save, port, sizeof(save));
/* We intentionally partially memset port */
/* coverity[suspicious_sizeof] */
/* coverity[suspicious_sizeof]
We intentionally partially memset port */
memset(port, 0, sizeof(save));
output_len = lldpd_port_serialize(port, (void**)&output);
memcpy(port, save, sizeof(save));
Expand Down Expand Up @@ -579,8 +579,8 @@ lldpd_decode(struct lldpd *cfg, char *frame, int s,
freed with lldpd_port_cleanup() and therefore, the refcount
of the chassis that was attached to it is decreased.
*/
/* TAILQ_REMOVE does the right thing */
/* coverity[use_after_free] */
/* coverity[use_after_free]
TAILQ_REMOVE does the right thing */
i = 0; TAILQ_FOREACH(aport, &hardware->h_rports, p_entries)
i++;
log_debug("decode", "%d neighbors for %s", i,
Expand Down

0 comments on commit 87dfd17

Please sign in to comment.