Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lldp: add option/command to override hostname #60

Merged
merged 2 commits into from
Apr 9, 2014

Conversation

jonasj76
Copy link
Contributor

@jonasj76 jonasj76 commented Apr 8, 2014

Allow to override the system name (hostname) by using '-N' as parameter to
lldpd, or by using "configure system hostname " to lldpcli.

Allow to override the system name (hostname) by using '-N' as parameter to
lldpd, or by using "configure system hostname <NAME>" to lldpcli.

Signed-off-by: Jonas Johansson <jonasj76@gmail.com>
@vincentbernat
Copy link
Member

Thanks for the patch! It looks good for me.

At some point in the future, I would like to remove most of the command line options in favor of the configuration files. I can merge your patch as is and remove the part adding the -N command-line flag or you can do it yourself or we can discuss why we should remove command line options (it's just that there are too many of them, now that we can use a configuration file, this seems redundant). Tell me what your prefer.

Too many flags being added, use of configuration file is prefered.

Signed-off-by: Jonas Johansson <jonasj76@gmail.com>
@jonasj76
Copy link
Contributor Author

jonasj76 commented Apr 9, 2014

I agree about not adding more command-line options. I didn't need the command-line flag in the first place, it was just added to look like the option to override platform and system description.
I made another commit which removed the -N command flag.

vincentbernat added a commit that referenced this pull request Apr 9, 2014
lldp: add option/command to override hostname
@vincentbernat vincentbernat merged commit f88a0f1 into lldpd:master Apr 9, 2014
@vincentbernat
Copy link
Member

Thanks!

@jonasj76 jonasj76 deleted the override-hostname branch April 9, 2014 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants