fix: use castPtr to avoid error on new text library
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to deal with the `useAsPtr` in the new version of the text library, which seems to pass `Ptr Word8` instead of `Ptr UChar`. It is probably safe to use `castPtr` for the same length, so I used it to solve the problem. I think it's safe to assume that the version that depends on the old text will just be the same with cast.
|
In stackage it is required for compatibility from lts-21. |
MangoIV
reviewed
Oct 26, 2023
| @@ -34,7 +34,7 @@ instance Show Transliterator where | |||
| transliterator :: Text -> IO Transliterator | |||
| transliterator spec = | |||
| useAsPtr spec $ \ptr len -> do | |||
| q <- handleError $ openTrans ptr (fromIntegral len) | |||
| q <- handleError $ openTrans (castPtr ptr) (fromIntegral len) | |||
There was a problem hiding this comment.
have you actually verified the tests pass against this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to deal with the
useAsPtrin the new version of the text library, which seems to passPtr Word8instead ofPtr UChar. It is probably safe to usecastPtrfor the same length, so I used it to solve the problem. I think it's safe to assume that the version that depends on the old text will just be the same with cast.