Fixed ClearRect unable to clear transparent image #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are right @ph1048, it's correct. It seems to not break anything. Thanks for your contribution. I'll merge your change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I am using draw2dimg to draw things on a transparent html5 canvas, and current implementation of ClearRect uses draw.Over operation, which is unable to clear image to a fully transparent state. I suggest using draw.Src, as it allows users to clear area with transparent pixels. IMO, for transparent images this behaviour is somewhat intuitive.
Also, this behaviour would not break existing behaviour for fully opaque clear operations.