Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Updates #56

Closed
wants to merge 1 commit into from
Closed

Minor Updates #56

wants to merge 1 commit into from

Conversation

StewPoll
Copy link
Contributor

Redundant & symbol in URL.
Added formatting to the error message.

Redundant & symbol in URL.
Added formatting to the error message.
@llimllib
Copy link
Owner

The <url|text> format doesn't work for me:

slack

@llimllib
Copy link
Owner

From the slack api docs:

If you want Slack to treat your message as completely unformatted, pass parse=full. This will ignore any markup formatting you added to your message.

We use that so that when plugins like !gif returns a plain URL it gets automatically linkified.

I guess I should add a method to the server that allows you to send a slack-formatted message? Would it be OK to just keep the full URL here for now?

Alternately, we could do something like the github plugin does

@llimllib
Copy link
Owner

Also, I've applied to the openweathermap team to have my key declared valid for the open source project so that we don't have to make people get a key, which would eliminate this problem.

@StewPoll
Copy link
Contributor Author

StewPoll commented Nov 1, 2015

Either would work.

In this instance having the API key declared valid for all would be the best for >this< plugin.

Having the option for formatted messages would be nice though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants