Skip to content

Commit

Permalink
readme: add link to introductory blog post
Browse files Browse the repository at this point in the history
  • Loading branch information
@mewmew
mewmew committed Nov 2, 2020
1 parent 47495a9 commit 96af489
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions README.md
View file
Expand Up @@ -7,6 +7,10 @@

Library for interacting with [LLVM IR](http://llvm.org/docs/LangRef.html) in pure Go.

## Introduction

* [Introductory blog post "LLVM IR and Go"](https://blog.gopheracademy.com/advent-2018/llvm-ir-and-go/)

## Installation

```bash
Expand Down

8 comments on commit 96af489

@dannypsnl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also link to document?

@mewmew
Copy link
Member Author

@mewmew mewmew commented on 96af489 Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also link to document?

Good idea.

@mewmew
Copy link
Member Author

@mewmew mewmew commented on 96af489 Nov 2, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dannypsnl would you do the commit adding a link to https://llir.github.io/document/?

@dannypsnl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@dannypsnl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and I found the test timeout, that's a bad signal. Any ideas to reduce unit test time? Or separate integration test part to its own Action, then we can set a longer time for it.

@mewmew
Copy link
Member Author

@mewmew mewmew commented on 96af489 Nov 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and I found the test timeout, that's a bad signal. Any ideas to reduce unit test time? Or separate integration test part to its own Action, then we can set a longer time for it.

We are running a lot of tests currently. Perhaps we could add a go test -short mode for regular development, and then use go test before releases? If you wish, feel free to look into updating the CI test actions. I think you are far more familiar with GitHub actions than I am @dannypsnl (with #142 and #144).

Cheers,
Robin

@dannypsnl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably would be ok, maybe run a full check on PR, short check on commit? We can have several actions for different purposes.

@dannypsnl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I want to remove Go 1.12 test, the old version would contain more and more problems out of exception. Supporting it would take effort but we have limited human resource, and the lastest version already move to 1.15, I tend to maintain three versions only.

Please sign in to comment.