Overloaded bytes transformer #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids using consts as dict keys by using id(obj) as hash keys instead, and using a second dict mapping id(obj) -> obj.
ssanderson
force-pushed
the
overloaded-bytes
branch
from
709dcff
to
cde9e85
Compare
| def visit_consts(self, consts): | ||
| return super().visit_consts( | ||
| tuple( | ||
| self.visit_consts(const) if isinstance(const, tuple) |
There was a problem hiding this comment.
@llllllllll it's possible that recursing through tuples like this should be the default behavior.
There was a problem hiding this comment.
do you mean default in codetransformer? Why, this doesn't make sense in lazy. I think that this is needed in this case and the float case.
You do need to look through frozensets though because of the peephole optimizer.
In [1]: def f():
...: return a in {1.0, 2.0}
...:
In [2]: f.__code__.co_consts[3]
Out[2]: frozenset({1.0, 2.0})
|
superceded by #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
overloaded bytestransformer that accepts a callable to apply over bytes literals in the decorated function.